Re: [PATCH v2 2/2] drm/xe/xe_survivability: Fix static analysis tool reported issues

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Dec 18, 2025 at 04:21:54PM +0530, Riana Tauro wrote:
> 1) Use static survivability info attributes.
> 2) Fix visibility condition
> 
> Fixes: f4e9fc967afd ("drm/xe/xe_survivability: Redesign survivability mode")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512101919.G12cuhBJ-lkp@intel.com/

I don't see the number 2 above listed here in this report.
What am I missing?

Also, I believe it deserves a separate commit with proper explanation even
if it ends up with same closes and reported by tag.

Sorry for not noticing this on the previous revision.

> Signed-off-by: Riana Tauro <riana.tauro@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_survivability_mode.c | 23 +++++++++++-----------
>  1 file changed, 12 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c
> index 2869866537ad..a25a23bcacc8 100644
> --- a/drivers/gpu/drm/xe/xe_survivability_mode.c
> +++ b/drivers/gpu/drm/xe/xe_survivability_mode.c
> @@ -221,15 +221,15 @@ static ssize_t survivability_info_show(struct device *dev,
>  		.index = _index,						\
>  	}
>  
> -SURVIVABILITY_ATTR_RO(capability_info, CAPABILITY_INFO);
> -SURVIVABILITY_ATTR_RO(postcode_trace, POSTCODE_TRACE);
> -SURVIVABILITY_ATTR_RO(postcode_trace_overflow, POSTCODE_TRACE_OVERFLOW);
> -SURVIVABILITY_ATTR_RO(aux_info0, AUX_INFO0);
> -SURVIVABILITY_ATTR_RO(aux_info1, AUX_INFO1);
> -SURVIVABILITY_ATTR_RO(aux_info2, AUX_INFO2);
> -SURVIVABILITY_ATTR_RO(aux_info3, AUX_INFO3);
> -SURVIVABILITY_ATTR_RO(aux_info4, AUX_INFO4);
> -SURVIVABILITY_ATTR_RO(fdo_mode, FDO_INFO);
> +static SURVIVABILITY_ATTR_RO(capability_info, CAPABILITY_INFO);
> +static SURVIVABILITY_ATTR_RO(postcode_trace, POSTCODE_TRACE);
> +static SURVIVABILITY_ATTR_RO(postcode_trace_overflow, POSTCODE_TRACE_OVERFLOW);
> +static SURVIVABILITY_ATTR_RO(aux_info0, AUX_INFO0);
> +static SURVIVABILITY_ATTR_RO(aux_info1, AUX_INFO1);
> +static SURVIVABILITY_ATTR_RO(aux_info2, AUX_INFO2);
> +static SURVIVABILITY_ATTR_RO(aux_info3, AUX_INFO3);
> +static SURVIVABILITY_ATTR_RO(aux_info4, AUX_INFO4);
> +static SURVIVABILITY_ATTR_RO(fdo_mode, FDO_INFO);
>  
>  static void xe_survivability_mode_fini(void *arg)
>  {
> @@ -252,9 +252,10 @@ static umode_t survivability_info_attrs_visible(struct kobject *kobj, struct att
>  	u32 *info = survivability->info;
>  
>  	/* FDO mode is visible only when supported */
> -	if (idx >= MAX_SCRATCH_REG && survivability->version >= 2)
> +	if (idx == MAX_SCRATCH_REG && survivability->version >= 2)
>  		return 0400;
> -	else if (info[idx])
> +
> +	if (idx < MAX_SCRATCH_REG && info[idx])
>  		return 0400;
>  
>  	return 0;
> -- 
> 2.47.1
>