Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: <fei.yang@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <matthew.d.roper@intel.com>
Subject: Re: [PATCH 1/1] drm/xe/cri: vram addr range is expanded to bit[17:8]
Date: Sun, 11 Jan 2026 13:47:32 -0800	[thread overview]
Message-ID: <aWQadEqbiBzu1ePh@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20260110053650.2241351-2-fei.yang@intel.com>

On Fri, Jan 09, 2026 at 09:36:50PM -0800, fei.yang@intel.com wrote:
> From: Fei Yang <fei.yang@intel.com>
> 
> There was a BSpec update to incorporate larger vram size.
> BSpec: 54991
> 
> Signed-off-by: Fei Yang <fei.yang@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_vram.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vram.c b/drivers/gpu/drm/xe/xe_vram.c
> index c64d98bf1723..2159d9c33bb1 100644
> --- a/drivers/gpu/drm/xe/xe_vram.c
> +++ b/drivers/gpu/drm/xe/xe_vram.c
> @@ -155,7 +155,10 @@ static int tile_vram_size(struct xe_tile *tile, u64 *vram_size,
>  		*tile_offset = 0;
>  	} else {
>  		reg = xe_mmio_read32(&tile->mmio, SG_TILE_ADDR_RANGE(tile->id));
> -		*tile_size = (u64)REG_FIELD_GET(GENMASK(14, 8), reg) * SZ_1G;
> +		if (xe->info.platform == XE_CRESCENTISLAND)

I suspect that all future platforms will want to use GENMASK(17, 8), so
maybe an IP version check (e.g., greater than CRI, use GENMASK(17, 8)).

Alternatively, since bits 17–15 are reserved on prior platforms, they
presumably just read as zero—so another option is to blindly use
GENMASK(17, 8).

Matt

> +			*tile_size = (u64)REG_FIELD_GET(GENMASK(17, 8), reg) * SZ_1G;
> +		else
> +			*tile_size = (u64)REG_FIELD_GET(GENMASK(14, 8), reg) * SZ_1G;
>  		*tile_offset = (u64)REG_FIELD_GET(GENMASK(7, 1), reg) * SZ_1G;
>  	}
>  
> -- 
> 2.43.0
> 

  reply	other threads:[~2026-01-11 21:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-10  5:36 [PATCH 0/1] drm/xe/cri: vram addr range is expanded to bit[17:8] fei.yang
2026-01-10  5:36 ` [PATCH 1/1] " fei.yang
2026-01-11 21:47   ` Matthew Brost [this message]
2026-01-12 21:00     ` Yang, Fei
2026-01-12 21:06       ` Matt Roper
2026-01-10  5:40 ` ✓ CI.KUnit: success for " Patchwork
2026-01-10  6:15 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-10  8:10 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWQadEqbiBzu1ePh@lstrano-desk.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=fei.yang@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox