From: Matthew Brost <matthew.brost@intel.com>
To: <fei.yang@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <matthew.d.roper@intel.com>
Subject: Re: [PATCH 1/1] drm/xe: vram addr range is expanded to bit[17:8]
Date: Mon, 12 Jan 2026 16:30:28 -0800 [thread overview]
Message-ID: <aWWSJKGcDgHuLv6R@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20260112220330.2267122-2-fei.yang@intel.com>
On Mon, Jan 12, 2026 at 02:03:30PM -0800, fei.yang@intel.com wrote:
> From: Fei Yang <fei.yang@intel.com>
>
> The bit field used to be [14:8] with [17:15] marked as SPARE and
> defaulted to 0. So, simply expand the read to bit[17:8] assuming
> the platforms using only bit[14:8] have zeros in the expanded bits.
>
> BSpec: 54991
>
> Signed-off-by: Fei Yang <fei.yang@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Also future reference single patches series do not need a cover letter.
Matt
> ---
> drivers/gpu/drm/xe/xe_vram.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_vram.c b/drivers/gpu/drm/xe/xe_vram.c
> index c64d98bf1723..4f807eade2b7 100644
> --- a/drivers/gpu/drm/xe/xe_vram.c
> +++ b/drivers/gpu/drm/xe/xe_vram.c
> @@ -155,7 +155,7 @@ static int tile_vram_size(struct xe_tile *tile, u64 *vram_size,
> *tile_offset = 0;
> } else {
> reg = xe_mmio_read32(&tile->mmio, SG_TILE_ADDR_RANGE(tile->id));
> - *tile_size = (u64)REG_FIELD_GET(GENMASK(14, 8), reg) * SZ_1G;
> + *tile_size = (u64)REG_FIELD_GET(GENMASK(17, 8), reg) * SZ_1G;
> *tile_offset = (u64)REG_FIELD_GET(GENMASK(7, 1), reg) * SZ_1G;
> }
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-01-13 0:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 22:03 [PATCH 0/1] drm/xe: vram addr range is expanded to bit[17:8] fei.yang
2026-01-12 22:03 ` [PATCH 1/1] " fei.yang
2026-01-13 0:30 ` Matthew Brost [this message]
2026-01-12 22:07 ` ✓ CI.KUnit: success for " Patchwork
2026-01-12 22:45 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-01-13 6:08 ` ✓ Xe.CI.Full: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWWSJKGcDgHuLv6R@lstrano-desk.jf.intel.com \
--to=matthew.brost@intel.com \
--cc=fei.yang@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox