Re: [PATCH v4 00/12] Context based TLB invalidations

[Matthew Brost <matthew.brost@intel.com>]

On Thu, Jan 15, 2026 at 05:25:56PM -0700, Summers, Stuart wrote:
> Ok at least today, this definitely is going to need to be included with
> [1]. Without that, I'm seeing DMAR faults and various other issues. But
> with [1], I haven't seen any issues yet around the
> registration/deregistration, so I think the ref count model here is
> sound (as discussed inline of course as well).
> 
> So:
> Tested-by: Stuart Summers <stuart.summers@intel.com>

Thanks.

> 
> The only concern I have at this point is around the ring invalidations.

I have one bug to fix around multi-q too.

> Maybe we can discuss more in that review, but I'm a little hessitant to
> put a full R-B on this series unless we also include that other one or
> fixes that you had suggested (which needs more debug still).
> 

I'm not sure ring invalidations is strickly related. I agree would
should reach on conclusion on what needs to be done there though.

I'm fairly behind at the moment. I think for ring invalidations it is
unfortunately going probably be at least week before I have bandwidth
to think about those :(.

Matt

> Thanks,
> Stuart
> 
> [1]: https://patchwork.freedesktop.org/series/160057/
> 
> On Mon, 2026-01-12 at 18:52 -0800, Matthew Brost wrote:
> > Add support for context based TLB invalidations.
> > 
> > Matt
> > 
> > Matthew Brost (12):
> >   drm/xe: Add normalize_invalidation_range
> >   drm/xe: Make usm.asid_to_vm allocation use GFP_NOWAIT
> >   drm/xe: Add has_ctx_tlb_inval to device info
> >   drm/xe: Add xe_device_asid_to_vm helper
> >   drm/xe: Add vm to exec queues association
> >   drm/xe: Taint TLB invalidation seqno lock with GFP_KERNEL
> >   drm/xe: Rename send_tlb_inval_ppgtt to send_tlb_inval_asid_ppgtt
> >   drm/xe: Add send_tlb_inval_ppgtt helper
> >   drm/xe: Add xe_tlb_inval_idle helper
> >   drm/xe: Add exec queue active vfunc
> >   drm/xe: Add context-based invalidation to GuC TLB invalidation
> > backend
> >   drm/xe: Enable context TLB invalidations for CI
> > 
> >  drivers/gpu/drm/xe/xe_device.c           |  25 +++
> >  drivers/gpu/drm/xe/xe_device.h           |  11 +-
> >  drivers/gpu/drm/xe/xe_device_types.h     |   9 +
> >  drivers/gpu/drm/xe/xe_exec_queue.c       |   7 +-
> >  drivers/gpu/drm/xe/xe_exec_queue_types.h |   5 +
> >  drivers/gpu/drm/xe/xe_execlist.c         |   7 +
> >  drivers/gpu/drm/xe/xe_guc_submit.c       |   6 +
> >  drivers/gpu/drm/xe/xe_guc_tlb_inval.c    | 238 ++++++++++++++++++---
> > --
> >  drivers/gpu/drm/xe/xe_pci.c              |   2 +
> >  drivers/gpu/drm/xe/xe_pci_types.h        |   1 +
> >  drivers/gpu/drm/xe/xe_tlb_inval.c        |  33 ++++
> >  drivers/gpu/drm/xe/xe_tlb_inval.h        |   2 +
> >  drivers/gpu/drm/xe/xe_vm.c               |  64 +++++-
> >  drivers/gpu/drm/xe/xe_vm.h               |   3 +
> >  drivers/gpu/drm/xe/xe_vm_types.h         |  16 ++
> >  15 files changed, 375 insertions(+), 54 deletions(-)
> > 
>