From: Matthew Brost <matthew.brost@intel.com>
To: Maarten Lankhorst <dev@lankhorst.se>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [RFC PATCH 0/3] drm/xe: Enable ATS.
Date: Mon, 26 Jan 2026 15:23:55 -0800 [thread overview]
Message-ID: <aXf3iylQYAVbxNfp@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20260126125207.1119351-1-dev@lankhorst.se>
On Mon, Jan 26, 2026 at 01:52:04PM +0100, Maarten Lankhorst wrote:
> RFC since I believe while the patches work, it might need some help to
> validate the semantics, and whether we want to set ATS unconditionally.
>
I think it would be good to perf numbers of various benchmarks /
workloads to determine the impact of ATS, plus maybe Kconfig / configfs
knob or something to toggle this for quick experiments.
Patches themselve make sense to me.
Matt
> Add the relevant wiring to enable the ATS flag in PASID, and add a minimal
> selftest to validate ATS works and doesn't break on the first access to
> system memory.
>
> Last patch is untested, hope to see what CI thinks. :-)
>
> Maarten Lankhorst (3):
> drm/xe: Force page fault
> drm/xe: Set the bits in PASID to enable ATS.
> drm/xe: Add migration selftest for validating job submission and basic
> features work
>
> drivers/gpu/drm/xe/regs/xe_gtt_defs.h | 1 +
> drivers/gpu/drm/xe/regs/xe_lrc_layout.h | 1 +
> drivers/gpu/drm/xe/xe_device.c | 7 ++++
> drivers/gpu/drm/xe/xe_lrc.c | 6 ++++
> drivers/gpu/drm/xe/xe_migrate.c | 46 +++++++++++++++++++++++++
> drivers/gpu/drm/xe/xe_migrate.h | 1 +
> drivers/gpu/drm/xe/xe_pt.c | 36 ++++++++++---------
> 7 files changed, 82 insertions(+), 16 deletions(-)
>
> --
> 2.51.0
>
next prev parent reply other threads:[~2026-01-26 23:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 12:52 [RFC PATCH 0/3] drm/xe: Enable ATS Maarten Lankhorst
2026-01-26 12:52 ` [RFC PATCH 1/3] drm/xe: Force page fault Maarten Lankhorst
2026-01-26 12:52 ` [RFC PATCH 2/3] drm/xe: Set the bits in PASID to enable ATS Maarten Lankhorst
2026-01-26 12:52 ` [RFC PATCH 3/3] drm/xe: Add migration selftest for validating job submission and basic features work Maarten Lankhorst
2026-01-26 19:19 ` Matthew Brost
2026-01-26 12:58 ` ✗ CI.checkpatch: warning for drm/xe: Enable ATS Patchwork
2026-01-26 13:00 ` ✓ CI.KUnit: success " Patchwork
2026-01-26 13:38 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-01-26 14:32 ` ✗ Xe.CI.Full: " Patchwork
2026-01-26 23:23 ` Matthew Brost [this message]
2026-01-27 8:01 ` ✗ Xe.CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXf3iylQYAVbxNfp@lstrano-desk.jf.intel.com \
--to=matthew.brost@intel.com \
--cc=dev@lankhorst.se \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox