Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Harish Chegondi <harish.chegondi@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
	Gustavo Sousa <gustavo.sousa@intel.com>
Subject: Re: [PATCH 1/1] drm/xe/xe2lpg: Extend Wa_18041344222 to graphics IP 20.04
Date: Wed, 28 Jan 2026 14:54:05 -0800	[thread overview]
Message-ID: <aXqTjcGrosLmqD7o@intel.com> (raw)
In-Reply-To: <20260127205004.GA2174980@mdroper-desk1.amr.corp.intel.com>

On Tue, Jan 27, 2026 at 12:50:04PM -0800, Matt Roper wrote:
> On Mon, Jan 26, 2026 at 11:49:50PM -0800, Harish Chegondi wrote:
> > Apply WA 18041344222 to Xe2 LPG graphics IP version 20.04 too.
> > 
> > Bspec: 56024
> > Cc: Matt Roper <matthew.d.roper@intel.com>
> > Cc: Gustavo Sousa <gustavo.sousa@intel.com>
> > Signed-off-by: Harish Chegondi <harish.chegondi@intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_wa.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> > index a991ee2b8781..1153a7363cff 100644
> > --- a/drivers/gpu/drm/xe/xe_wa.c
> > +++ b/drivers/gpu/drm/xe/xe_wa.c
> > @@ -535,6 +535,13 @@ static const struct xe_rtp_entry_sr engine_was[] = {
> >  		       FUNC(xe_rtp_match_first_render_or_compute)),
> >  	  XE_RTP_ACTIONS(SET(TDL_TSL_CHICKEN, RES_CHK_SPR_DIS))
> >  	},
> > +	{ XE_RTP_NAME("18041344222"),
> > +	  XE_RTP_RULES(GRAPHICS_VERSION(2004),
> > +		       FUNC(xe_rtp_match_first_render_or_compute),
> > +		       FUNC(xe_rtp_match_not_sriov_vf),
> 
> We don't need this; nothing on the engine_was[] list applied to SRIOV
> VFs so we never apply any of them.  This RTP match function is intended
> for OOB functions (and possibly LRC workarounds).

I added this to xe2hpg too earlier after I noticed some SRIOV test
failures on CI: https://patchwork.freedesktop.org/series/153187/
I can no longer access those test failures that failed back then. 
Maybe I can remove the line for xe2_hpg and have the tests run again
on CI. The line was added to the xe3_lpg WA too.

I will verify once again.

Thank You
Harish.
> 
> 
> Matt
> 
> > +		       FUNC(xe_rtp_match_gt_has_discontiguous_dss_groups)),
> > +	  XE_RTP_ACTIONS(SET(TDL_CHICKEN, EUSTALL_PERF_SAMPLING_DISABLE))
> > +	},
> >  
> >  	/* Xe2_HPG */
> >  
> > -- 
> > 2.43.0
> > 
> 
> -- 
> Matt Roper
> Graphics Software Engineer
> Linux GPU Platform Enablement
> Intel Corporation

  reply	other threads:[~2026-01-28 22:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27  7:49 [PATCH 1/1] drm/xe/xe2lpg: Extend Wa_18041344222 to graphics IP 20.04 Harish Chegondi
2026-01-27  8:04 ` ✓ CI.KUnit: success for series starting with [1/1] " Patchwork
2026-01-27  8:45 ` [PATCH 1/1] " Bhadane, Dnyaneshwar
2026-01-27 10:28 ` ✗ Xe.CI.Full: failure for series starting with [1/1] " Patchwork
2026-01-27 20:50 ` [PATCH 1/1] " Matt Roper
2026-01-28 22:54   ` Harish Chegondi [this message]
2026-01-30  0:48   ` Harish Chegondi
2026-01-30 18:28     ` Matt Roper
2026-02-03  0:16       ` Harish Chegondi
2026-02-10 21:55       ` Harish Chegondi
2026-01-28  7:42 ` ✗ Xe.CI.Full: failure for series starting with [1/1] " Patchwork
2026-01-28  7:45 ` ✓ CI.KUnit: success " Patchwork
2026-01-28 15:07 ` ✓ CI.KUnit: success for series starting with [1/1] drm/xe/xe2lpg: Extend Wa_18041344222 to graphics IP 20.04 (rev2) Patchwork
2026-01-28 15:51 ` ✓ Xe.CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXqTjcGrosLmqD7o@intel.com \
    --to=harish.chegondi@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox