Re: [PATCH v1] drm/xe/irq: Introduce xe_irq_init_late()

[Raag Jadav <raag.jadav@intel.com>]

On Mon, Feb 02, 2026 at 05:14:29PM +0530, Raag Jadav wrote:
> Introduce xe_irq_init_late() which will enable the IRQs at the end of
> xe_device_probe() to make sure we don't hit them during probe sequence.
> 
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
> PS: I'm not aware of any historic significance of current sequence.
> If I've missed anything, please let me know.

As per CI results, this looks like a bad idea. Sorry about the noise.

Raag

>  drivers/gpu/drm/xe/xe_device.c |  3 +++
>  drivers/gpu/drm/xe/xe_irq.c    | 10 ++++++++--
>  drivers/gpu/drm/xe/xe_irq.h    |  1 +
>  3 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 9cf82bde36c4..40c27e62bc01 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -1013,6 +1013,9 @@ int xe_device_probe(struct xe_device *xe)
>  
>  	detect_preproduction_hw(xe);
>  
> +	/* Turn irqs on only after we're setup to service them */
> +	xe_irq_init_late(xe);
> +
>  	return devm_add_action_or_reset(xe->drm.dev, xe_device_sanitize, xe);
>  
>  err_unregister_display:
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index 7560a45f7f64..bf554268762e 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -802,6 +802,14 @@ int xe_irq_init(struct xe_device *xe)
>  	return xe_irq_msix_init(xe);
>  }
>  
> +void xe_irq_init_late(struct xe_device *xe)
> +{
> +	if (!atomic_read(&xe->irq.enabled))
> +		return;
> +
> +	xe_irq_postinstall(xe);
> +}
> +
>  int xe_irq_install(struct xe_device *xe)
>  {
>  	struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
> @@ -831,8 +839,6 @@ int xe_irq_install(struct xe_device *xe)
>  
>  	atomic_set(&xe->irq.enabled, 1);
>  
> -	xe_irq_postinstall(xe);
> -
>  	return devm_add_action_or_reset(xe->drm.dev, irq_uninstall, xe);
>  }
>  
> diff --git a/drivers/gpu/drm/xe/xe_irq.h b/drivers/gpu/drm/xe/xe_irq.h
> index a28bd577ba52..ad03e830a0b0 100644
> --- a/drivers/gpu/drm/xe/xe_irq.h
> +++ b/drivers/gpu/drm/xe/xe_irq.h
> @@ -15,6 +15,7 @@ struct xe_tile;
>  struct xe_gt;
>  
>  int xe_irq_init(struct xe_device *xe);
> +void xe_irq_init_late(struct xe_device *xe);
>  int xe_irq_install(struct xe_device *xe);
>  void xe_irq_suspend(struct xe_device *xe);
>  void xe_irq_resume(struct xe_device *xe);
> -- 
> 2.43.0
>