Re: [PATCH v1] drm/xe: Send unknown recovery method for XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET

[Raag Jadav <raag.jadav@intel.com>]

On Thu, Feb 05, 2026 at 05:54:29PM -0500, Rodrigo Vivi wrote:
> On Thu, Feb 05, 2026 at 04:48:35PM +0530, Raag Jadav wrote:
> > XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET is intended for debugging hangs,
> > so wedge the device without any recovery method (unknown) and have it
> > available to the user for debugging.
> > 
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_device.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> > index b1241fa4c3d6..815f0b0c9dfd 100644
> > --- a/drivers/gpu/drm/xe/xe_device.c
> > +++ b/drivers/gpu/drm/xe/xe_device.c
> > @@ -1326,8 +1326,15 @@ void xe_device_declare_wedged(struct xe_device *xe)
> >  		xe_gt_declare_wedged(gt);
> >  
> >  	if (xe_device_wedged(xe)) {
> > +		/*
> > +		 * XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET is intended for debugging hangs,
> > +		 * so wedge the device without any recovery method and have it available
> > +		 * to the user for debugging.
> 
> agree....
> 
> > +		 */
> > +		if (xe->wedged.mode == XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET)
> > +			xe_device_set_wedged_method(xe, 0);
> 
> but why not using the already defined:
> 
> #define DRM_WEDGE_RECOVERY_NONE    BIT(0)  /* optional telemetry collection */

We originally added this for AMD usecase, and it doesn't strictly speaking
means 'wedged'.

Documentation/gpu/drm-uapi.rst +441

"The only exception to this is ``WEDGED=none``, which signifies that the device
was temporarily 'wedged' at some point but was recovered from driver context
using device specific methods like reset."

Raag

> >  		/* If no wedge recovery method is set, use default */
> > -		if (!xe->wedged.method)
> > +		else if (!xe->wedged.method)
> >  			xe_device_set_wedged_method(xe, DRM_WEDGE_RECOVERY_REBIND |
> >  						    DRM_WEDGE_RECOVERY_BUS_RESET);
> >  
> > -- 
> > 2.43.0
> >