Re: [PATCH v1 1/4] drm/xe/queue: Call fini on exec queue creation fail

[Matthew Brost <matthew.brost@intel.com>]

On Fri, Feb 06, 2026 at 03:53:31PM +0100, Tomasz Lis wrote:
> Every call to queue init should have a corresponding fini call.
> Skipping this would mean skipping removal of the queue from GuC list
> (which is part of guc_id allocation). A damaged queue stored in
> exec_queue_lookup list would lead to invalid memory reference,
> sooner or later.
> 
> Call fini to free guc_id. This must be done before any internal
> LRCs are freed.
> 
> Fixes: 3c1fa4aa60b1 ("drm/xe: Move queue init before LRC creation")
> Signed-off-by: Tomasz Lis <tomasz.lis@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_exec_queue.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
> index 66d0e10ee2c4..42849be46166 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue.c
> +++ b/drivers/gpu/drm/xe/xe_exec_queue.c
> @@ -324,6 +324,8 @@ static int __xe_exec_queue_init(struct xe_exec_queue *q, u32 exec_queue_flags)
>  	return 0;
>  
>  err_lrc:
> +	q->ops->fini(q);
> +
>  	for (i = i - 1; i >= 0; --i)
>  		xe_lrc_put(q->lrc[i]);
>  	return err;
> -- 
> 2.25.1
>