From: Matthew Brost <matthew.brost@intel.com>
To: "Piórkowski, Piotr" <piotr.piorkowski@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v1] drm/xe: Force EXEC_QUEUE_FLAG_KERNEL for kernel internal VMs
Date: Wed, 11 Feb 2026 09:44:33 -0800 [thread overview]
Message-ID: <aYzAAT1XLIpPyxBx@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20260211171441.3246686-1-piotr.piorkowski@intel.com>
On Wed, Feb 11, 2026 at 06:14:41PM +0100, Piórkowski, Piotr wrote:
> From: Piotr Piórkowski <piotr.piorkowski@intel.com>
>
> VMs created without an associated xe_file originate from kernel
> contexts and should use kernel exec queues. Ensure such VMs
> create bind exec queues with EXEC_QUEUE_FLAG_KERNEL set.
> Let's ensure bind exec queues created for kernel VMs are always
> marked with EXEC_QUEUE_FLAG_KERNEL.
>
> Signed-off-by: Piotr Piórkowski <piotr.piorkowski@intel.com>
> ---
> drivers/gpu/drm/xe/xe_vm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 8fe54a998385..708e8c7becf8 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -1657,6 +1657,9 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags, struct xe_file *xef)
> if (!vm->pt_root[id])
> continue;
>
> + if (!xef) /* Not from userspace */
> + create_flags |= EXEC_QUEUE_FLAG_KERNEL;
This LGTM, but for completness we should probably remove setting
EXEC_QUEUE_FLAG_KERNEL at all callers too.
Matt
> +
> q = xe_exec_queue_create_bind(xe, tile, vm, create_flags, 0);
> if (IS_ERR(q)) {
> err = PTR_ERR(q);
> --
> 2.34.1
>
next prev parent reply other threads:[~2026-02-11 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 17:14 [PATCH v1] drm/xe: Force EXEC_QUEUE_FLAG_KERNEL for kernel internal VMs Piórkowski, Piotr
2026-02-11 17:22 ` ✓ CI.KUnit: success for " Patchwork
2026-02-11 17:44 ` Matthew Brost [this message]
2026-02-12 17:38 ` [PATCH v1] " Matthew Brost
2026-02-11 18:01 ` ✗ Xe.CI.BAT: failure for " Patchwork
2026-02-13 9:07 ` Piotr Piórkowski
2026-02-13 2:36 ` ✗ Xe.CI.FULL: " Patchwork
2026-02-13 9:10 ` Piotr Piórkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYzAAT1XLIpPyxBx@lstrano-desk.jf.intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=piotr.piorkowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox