From: "Vivekanandan, Balasubramani" <balasubramani.vivekanandan@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>, <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v2 21/23] drm/xe/xe2_hpg: Drop invalid workaround Wa_15010599737
Date: Tue, 24 Feb 2026 15:10:37 +0530 [thread overview]
Message-ID: <aZ1yFYuCXcxZqVgd@bvivekan-mob1> (raw)
In-Reply-To: <20260220-forupstream-wa_cleanup-v2-21-b12005a05af6@intel.com>
On 20.02.2026 09:27, Matt Roper wrote:
> Wa_15010599737 was a workaround originally proposed (and ultimately
> rejected) for DG2-G10. There's no record of it ever being relevant or
> even considered for any other platforms.
>
> The specific bit this workaround was setting is documented as "This bit
> should be set to 1 for the DX9 API and 0 for all other APIs" which means
> that it should almost always be left at the default value of 0 on Linux.
> The register itself is directly accessible from userspace, so in the
> special cases where it might be relevant (e.g., Wine/Proton running
> Windows DX9 apps), the userspace drivers already have the ability to
> change the setting without involvement of the kernel.
>
> Fixes: 7f3ee7d88058 ("drm/xe/xe2hpg: Add initial GT workarounds")
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
LGTM.
Reviewed-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Regards,
Bala
> ---
> drivers/gpu/drm/xe/xe_wa.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_wa.c b/drivers/gpu/drm/xe/xe_wa.c
> index fa5dce4ead48bae424a49c62142683dbf1971376..105ccd8115f09993b7ef82e70cb87d74008f267f 100644
> --- a/drivers/gpu/drm/xe/xe_wa.c
> +++ b/drivers/gpu/drm/xe/xe_wa.c
> @@ -734,10 +734,7 @@ static const struct xe_rtp_entry_sr lrc_was[] = {
> },
>
> /* Xe2_HPG */
> - { XE_RTP_NAME("15010599737"),
> - XE_RTP_RULES(GRAPHICS_VERSION(2001), ENGINE_CLASS(RENDER)),
> - XE_RTP_ACTIONS(SET(CHICKEN_RASTER_1, DIS_SF_ROUND_NEAREST_EVEN))
> - },
> +
> { XE_RTP_NAME("14020756599"),
> XE_RTP_RULES(GRAPHICS_VERSION(2001), ENGINE_CLASS(RENDER)),
> XE_RTP_ACTIONS(SET(WM_CHICKEN3, HIZ_PLANE_COMPRESSION_DIS))
>
> --
> 2.53.0
>
next prev parent reply other threads:[~2026-02-24 9:41 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 17:27 [PATCH v2 00/23] Workaround cleanup & simplification Matt Roper
2026-02-20 17:27 ` [PATCH v2 01/23] drm/xe/mtl: Drop pre-prod workarounds Wa_14015795083 & Wa_14014475959 Matt Roper
2026-02-23 7:57 ` Vivekanandan, Balasubramani
2026-02-20 17:27 ` [PATCH v2 02/23] drm/xe/pvc: Drop pre-prod workarounds Matt Roper
2026-02-23 8:27 ` Vivekanandan, Balasubramani
2026-02-20 17:27 ` [PATCH v2 03/23] drm/xe/wa: Document new policy regarding workaround IP ranges Matt Roper
2026-02-20 17:27 ` [PATCH v2 04/23] drm/xe: Consolidate workaround entries for Wa_16021867713 Matt Roper
2026-02-23 9:57 ` Vivekanandan, Balasubramani
2026-02-20 17:27 ` [PATCH v2 05/23] drm/xe: Consolidate workaround entries for Wa_14019449301 Matt Roper
2026-02-23 10:00 ` Vivekanandan, Balasubramani
2026-02-20 17:27 ` [PATCH v2 06/23] drm/xe: Consolidate workaround entries for Wa_16028005424 Matt Roper
2026-02-23 14:03 ` Vivekanandan, Balasubramani
2026-02-20 17:27 ` [PATCH v2 07/23] drm/xe: Consolidate workaround entries for Wa_16021865536 Matt Roper
2026-02-23 14:08 ` Vivekanandan, Balasubramani
2026-02-20 17:27 ` [PATCH v2 08/23] drm/xe: Consolidate workaround entries for Wa_18032247524 Matt Roper
2026-02-23 14:12 ` Vivekanandan, Balasubramani
2026-02-20 17:27 ` [PATCH v2 09/23] drm/xe: Consolidate workaround entries for Wa_16018712365 Matt Roper
2026-02-23 14:16 ` Vivekanandan, Balasubramani
2026-02-20 17:27 ` [PATCH v2 10/23] drm/xe: Consolidate workaround entries for Wa_14020338487 Matt Roper
2026-02-23 14:19 ` Vivekanandan, Balasubramani
2026-02-20 17:27 ` [PATCH v2 11/23] drm/xe: Consolidate workaround entries for Wa_14018471104 Matt Roper
2026-02-23 14:21 ` Vivekanandan, Balasubramani
2026-02-20 17:27 ` [PATCH v2 12/23] drm/xe: Consolidate workaround entries for Wa_16021639441 Matt Roper
2026-02-23 15:04 ` Vivekanandan, Balasubramani
2026-02-20 17:27 ` [PATCH v2 13/23] drm/xe: Consolidate workaround entries for Wa_14021402888 Matt Roper
2026-02-23 22:25 ` Lin, Shuicheng
2026-02-20 17:27 ` [PATCH v2 14/23] drm/xe: Consolidate workaround entries for Wa_13012615864 Matt Roper
2026-02-23 21:53 ` Lin, Shuicheng
2026-02-20 17:27 ` [PATCH v2 15/23] drm/xe: Consolidate workaround entries for Wa_18041344222 Matt Roper
2026-02-23 21:47 ` Lin, Shuicheng
2026-02-23 21:51 ` Matt Roper
2026-02-20 17:27 ` [PATCH v2 16/23] drm/xe: Consolidate workaround entries for Wa_14019877138 Matt Roper
2026-02-23 21:33 ` Lin, Shuicheng
2026-02-23 21:41 ` Matt Roper
2026-02-23 22:35 ` Lin, Shuicheng
2026-02-20 17:27 ` [PATCH v2 17/23] drm/xe: Consolidate workaround entries for Wa_14019386621 Matt Roper
2026-02-23 19:11 ` Lin, Shuicheng
2026-02-20 17:27 ` [PATCH v2 18/23] drm/xe: Consolidate workaround entries for Wa_14019988906 Matt Roper
2026-02-23 21:56 ` Lin, Shuicheng
2026-02-20 17:27 ` [PATCH v2 19/23] drm/xe: Consolidate workaround entries for Wa_18033852989 Matt Roper
2026-02-23 19:14 ` Lin, Shuicheng
2026-02-20 17:27 ` [PATCH v2 20/23] drm/xe: Consolidate workaround entries for Wa_15016589081 Matt Roper
2026-02-23 19:06 ` Lin, Shuicheng
2026-02-20 17:27 ` [PATCH v2 21/23] drm/xe/xe2_hpg: Drop invalid workaround Wa_15010599737 Matt Roper
2026-02-24 9:40 ` Vivekanandan, Balasubramani [this message]
2026-02-20 17:27 ` [PATCH v2 22/23] drm/xe/wa_oob: Consolidate some OOB rules Matt Roper
2026-02-23 22:44 ` Lin, Shuicheng
2026-02-20 17:27 ` [PATCH v2 23/23] drm/xe: Consolidate workaround entries for Wa_14023061436 Matt Roper
2026-02-23 22:47 ` Lin, Shuicheng
2026-02-20 19:05 ` ✓ CI.KUnit: success for Workaround cleanup & simplification (rev2) Patchwork
2026-02-20 19:46 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-23 7:23 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-24 0:07 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZ1yFYuCXcxZqVgd@bvivekan-mob1 \
--to=balasubramani.vivekanandan@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox