Re: [PATCH] drm/pagemap: Unlock cache->lock before freeing it

[Matthew Brost <matthew.brost@intel.com>]

On Tue, Feb 24, 2026 at 02:39:17PM +0100, Maarten Lankhorst wrote:
> Hey,
> 
> Den 2026-02-23 kl. 23:29, skrev Matthew Brost:
> > From: Bart Van Assche <bvanassche@acm.org>
> > 
> > Although freeing a spinlock without unlocking it is fine, this confuses
> > static analyzers. Hence this patch.
> > 
> > Fixes: 77f14f2f2d73 ("drm/pagemap: Add a drm_pagemap cache and shrinker")
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> > Cc: Matthew Brost <matthew.brost@intel.com>
> > Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> > Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> > ---
> >  drivers/gpu/drm/drm_pagemap_util.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_pagemap_util.c b/drivers/gpu/drm/drm_pagemap_util.c
> > index 14ddb948a32e..50cb5f9cdac5 100644
> > --- a/drivers/gpu/drm/drm_pagemap_util.c
> > +++ b/drivers/gpu/drm/drm_pagemap_util.c
> > @@ -74,6 +74,8 @@ static void drm_pagemap_cache_fini(void *arg)
> >  		cache->dpagemap = NULL;
> >  		spin_unlock(&cache->lock);
> >  		drm_pagemap_destroy(dpagemap, false);
> > +	} else {
> > +		spin_unlock(&cache->lock);
> >  	}
> >  
> >  out:
> 
> What about this idea?
> 
> https://lore.kernel.org/all/791538fb-56e5-4ca5-9484-1180cc928a70@linux.intel.com/

Yes, that's better - I reposted this yesterday while a bit overloaded to
make sure this didn't get lost. Let's use the a version posted in the
above link.

Matt