From: Raag Jadav <raag.jadav@intel.com>
To: Riana Tauro <riana.tauro@intel.com>
Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
aravind.iddamsetty@linux.intel.com, anshuman.gupta@intel.com,
rodrigo.vivi@intel.com, joonas.lahtinen@linux.intel.com,
simona.vetter@ffwll.ch, airlied@gmail.com, pratik.bari@intel.com,
joshua.santosh.ranjan@intel.com, ashwin.kumar.kulkarni@intel.com,
shubham.kumar@intel.com, ravi.kishore.koppuravuri@intel.com
Subject: Re: [PATCH v6 2/5] drm/xe/xe_drm_ras: Add support for XE DRM RAS
Date: Mon, 16 Feb 2026 10:58:48 +0100 [thread overview]
Message-ID: <aZLqWI9cOdBXNxeB@black.igk.intel.com> (raw)
In-Reply-To: <20260216064726.2542819-9-riana.tauro@intel.com>
On Mon, Feb 16, 2026 at 12:17:28PM +0530, Riana Tauro wrote:
> Allocate correctable, uncorrectable nodes for every xe device. Each node
> contains error component, counters and respective query counter functions.
>
> Add basic functionality to create and register drm nodes.
...
> +static void cleanup_node_param(struct xe_drm_ras *ras, const enum drm_xe_ras_error_severity severity)
> +{
> + struct drm_ras_node *node = &ras->node[severity];
> +
> + kfree(node->device_name);
> + kfree(ras->info[severity]);
> +
> + node->device_name = NULL;
> + ras->info[severity] = NULL;
> +}
Nit: Unwind is usually in LIFO order, but this doesn't particularly look
harmful either. So upto you.
Raag
next prev parent reply other threads:[~2026-02-16 9:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 6:47 [PATCH v6 0/5] Introduce DRM_RAS using generic netlink for RAS Riana Tauro
2026-02-16 6:47 ` [PATCH v6 1/5] drm/ras: Introduce the DRM RAS infrastructure over generic netlink Riana Tauro
2026-02-16 6:47 ` [PATCH v6 2/5] drm/xe/xe_drm_ras: Add support for XE DRM RAS Riana Tauro
2026-02-16 9:58 ` Raag Jadav [this message]
2026-02-16 6:47 ` [PATCH v6 3/5] drm/xe/xe_hw_error: Integrate DRM RAS with hardware error handling Riana Tauro
2026-02-16 10:00 ` Raag Jadav
2026-02-16 6:47 ` [PATCH v6 4/5] drm/xe/xe_hw_error: Add support for Core-Compute errors Riana Tauro
2026-02-16 10:14 ` Raag Jadav
2026-02-16 6:47 ` [PATCH v6 5/5] drm/xe/xe_hw_error: Add support for PVC SoC errors Riana Tauro
2026-02-16 10:21 ` Raag Jadav
2026-02-16 6:59 ` ✓ Xe.CI.BAT: success for Introduce DRM_RAS using generic netlink for RAS (rev6) Patchwork
2026-02-16 8:02 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZLqWI9cOdBXNxeB@black.igk.intel.com \
--to=raag.jadav@intel.com \
--cc=airlied@gmail.com \
--cc=anshuman.gupta@intel.com \
--cc=aravind.iddamsetty@linux.intel.com \
--cc=ashwin.kumar.kulkarni@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=joshua.santosh.ranjan@intel.com \
--cc=pratik.bari@intel.com \
--cc=ravi.kishore.koppuravuri@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=shubham.kumar@intel.com \
--cc=simona.vetter@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox