From: Raag Jadav <raag.jadav@intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-xe@lists.freedesktop.org, matthew.brost@intel.com,
rodrigo.vivi@intel.com, riana.tauro@intel.com,
michal.wajdeczko@intel.com, umesh.nerlige.ramappa@intel.com,
mallesh.koujalagi@intel.com
Subject: Re: [PATCH v1 1/3] drm/xe/cri: Setup hardware error routing
Date: Thu, 19 Feb 2026 09:36:04 +0100 [thread overview]
Message-ID: <aZbLdKls0XRHIOOo@black.igk.intel.com> (raw)
In-Reply-To: <20260217214751.GE52346@mdroper-desk1.amr.corp.intel.com>
On Tue, Feb 17, 2026 at 01:47:51PM -0800, Matt Roper wrote:
> On Tue, Feb 17, 2026 at 05:16:31PM +0530, Raag Jadav wrote:
> > Setup hardware error routing based on XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET
...
> > + if (xe->info.platform == XE_CRESCENTISLAND)
> > + xe_hw_error_irq_route(xe);
>
> What makes this CRI-only? The DEV_ERR_ROUTING_CTRL register exists on
> every platform supported by the Xe driver so there doesn't appear to be
> any specific hardware dependency here.
>
> Even if there was a hardware dependency, we generally don't want to tie
> behavior to platforms; better to set a feature flag in the device
> descriptor that indicates which platforms can/can't support it.
This will be replaced with if (xe->info.has_sysctrl) once the original
series lands.
[1] https://patchwork.freedesktop.org/series/159554/
Raag
next prev parent reply other threads:[~2026-02-19 8:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 11:46 [PATCH v1 0/3] Hardware Error handling for Crescent Island Raag Jadav
2026-02-17 11:46 ` [PATCH v1 1/3] drm/xe/cri: Setup hardware error routing Raag Jadav
2026-02-17 21:47 ` Matt Roper
2026-02-19 8:36 ` Raag Jadav [this message]
2026-03-26 12:49 ` Mallesh, Koujalagi
2026-04-01 18:21 ` Raag Jadav
2026-02-17 11:46 ` [PATCH v1 2/3] drm/xe/hw_error: Reuse CSC worker for generic error handling Raag Jadav
2026-02-17 11:46 ` [PATCH v1 3/3] drm/xe/cri: Wedge the device on hardware error Raag Jadav
2026-02-17 22:10 ` Matt Roper
2026-02-17 12:42 ` ✓ CI.KUnit: success for Hardware Error handling for Crescent Island Patchwork
2026-02-17 13:52 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-02-17 16:14 ` ✓ Xe.CI.FULL: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZbLdKls0XRHIOOo@black.igk.intel.com \
--to=raag.jadav@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=mallesh.koujalagi@intel.com \
--cc=matthew.brost@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox