From: Matthew Brost <matthew.brost@intel.com>
To: Varun Gupta <varun.gupta@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <matthew.d.roper@intel.com>,
<himal.prasad.ghimiray@intel.com>, <priyanka.dandamudi@intel.com>,
<stuart.summers@intel.com>
Subject: Re: [PATCH v5 1/2] drm/xe: Add counter for invalid prefetch pagefaults
Date: Sun, 22 Feb 2026 20:35:20 -0800 [thread overview]
Message-ID: <aZvZCI7Taku+538A@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20260223040729.1157739-2-varun.gupta@intel.com>
On Mon, Feb 23, 2026 at 09:37:28AM +0530, Varun Gupta wrote:
> Add a stats counter for invalid prefetch page faults to avoid
> excessive logging.
>
> Originally-by: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Varun Gupta <varun.gupta@intel.com>
>
> ---
> v3:
> - New patch splitting stats counter from main prefetch implementation (Matt Brost)
> - Renamed from PREFETCH_PAGEFAULT_COUNT to INVALID_PREFETCH_PAGEFAULT_COUNT (Matt Brost)
> ---
> drivers/gpu/drm/xe/xe_gt_stats.c | 1 +
> drivers/gpu/drm/xe/xe_gt_stats_types.h | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_stats.c b/drivers/gpu/drm/xe/xe_gt_stats.c
> index 8ed0160a6041..81cec441b449 100644
> --- a/drivers/gpu/drm/xe/xe_gt_stats.c
> +++ b/drivers/gpu/drm/xe/xe_gt_stats.c
> @@ -60,6 +60,7 @@ static const char *const stat_description[__XE_GT_STATS_NUM_IDS] = {
> DEF_STAT_STR(SVM_TLB_INVAL_US, "svm_tlb_inval_us"),
> DEF_STAT_STR(VMA_PAGEFAULT_COUNT, "vma_pagefault_count"),
> DEF_STAT_STR(VMA_PAGEFAULT_KB, "vma_pagefault_kb"),
> + DEF_STAT_STR(INVALID_PREFETCH_PAGEFAULT_COUNT, "invalid_prefetch_pagefault_count"),
> DEF_STAT_STR(SVM_4K_PAGEFAULT_COUNT, "svm_4K_pagefault_count"),
> DEF_STAT_STR(SVM_64K_PAGEFAULT_COUNT, "svm_64K_pagefault_count"),
> DEF_STAT_STR(SVM_2M_PAGEFAULT_COUNT, "svm_2M_pagefault_count"),
> diff --git a/drivers/gpu/drm/xe/xe_gt_stats_types.h b/drivers/gpu/drm/xe/xe_gt_stats_types.h
> index 79568591bd67..b6081c312474 100644
> --- a/drivers/gpu/drm/xe/xe_gt_stats_types.h
> +++ b/drivers/gpu/drm/xe/xe_gt_stats_types.h
> @@ -15,6 +15,7 @@ enum xe_gt_stats_id {
> XE_GT_STATS_ID_SVM_TLB_INVAL_US,
> XE_GT_STATS_ID_VMA_PAGEFAULT_COUNT,
> XE_GT_STATS_ID_VMA_PAGEFAULT_KB,
> + XE_GT_STATS_ID_INVALID_PREFETCH_PAGEFAULT_COUNT,
> XE_GT_STATS_ID_SVM_4K_PAGEFAULT_COUNT,
> XE_GT_STATS_ID_SVM_64K_PAGEFAULT_COUNT,
> XE_GT_STATS_ID_SVM_2M_PAGEFAULT_COUNT,
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-02-23 4:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 4:07 [PATCH v5 0/2] drm/xe: Add prefetch pagefault support for Xe3p Varun Gupta
2026-02-23 4:07 ` [PATCH v5 1/2] drm/xe: Add counter for invalid prefetch pagefaults Varun Gupta
2026-02-23 4:35 ` Matthew Brost [this message]
2026-02-23 4:07 ` [PATCH v5 2/2] drm/xe: Add prefetch fault support for Xe3p Varun Gupta
2026-02-23 4:34 ` Matthew Brost
2026-02-23 4:41 ` Matthew Brost
2026-02-23 4:14 ` ✗ CI.checkpatch: warning for drm/xe: Add prefetch pagefault support for Xe3p (rev5) Patchwork
2026-02-23 4:15 ` ✓ CI.KUnit: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZvZCI7Taku+538A@lstrano-desk.jf.intel.com \
--to=matthew.brost@intel.com \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
--cc=priyanka.dandamudi@intel.com \
--cc=stuart.summers@intel.com \
--cc=varun.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox