Re: [PATCH] drm/xe: Don't expose display modparam if no display support

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Feb 16, 2026 at 07:32:40PM +0100, Michal Wajdeczko wrote:
> With CONFIG_DRM_XE_DISPLAY=n the display support will be compiled
> out, so exposing probe_display modparam is pointless.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

thanks for confirming the command is ignored when not declared.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_defaults.h | 2 +-
>  drivers/gpu/drm/xe/xe_module.c   | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_defaults.h b/drivers/gpu/drm/xe/xe_defaults.h
> index 5d5d41d067c5..c8ae1d5f3d60 100644
> --- a/drivers/gpu/drm/xe/xe_defaults.h
> +++ b/drivers/gpu/drm/xe/xe_defaults.h
> @@ -13,7 +13,7 @@
>  #define XE_DEFAULT_GUC_LOG_LEVEL		1
>  #endif
>  
> -#define XE_DEFAULT_PROBE_DISPLAY		true
> +#define XE_DEFAULT_PROBE_DISPLAY		IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
>  #define XE_DEFAULT_VRAM_BAR_SIZE		0
>  #define XE_DEFAULT_FORCE_PROBE			CONFIG_DRM_XE_FORCE_PROBE
>  #define XE_DEFAULT_MAX_VFS			~0
> diff --git a/drivers/gpu/drm/xe/xe_module.c b/drivers/gpu/drm/xe/xe_module.c
> index 903d3b433421..4cb578182912 100644
> --- a/drivers/gpu/drm/xe/xe_module.c
> +++ b/drivers/gpu/drm/xe/xe_module.c
> @@ -39,9 +39,11 @@ MODULE_PARM_DESC(svm_notifier_size, "Set the svm notifier size in MiB, must be p
>  module_param_named_unsafe(force_execlist, xe_modparam.force_execlist, bool, 0444);
>  MODULE_PARM_DESC(force_execlist, "Force Execlist submission");
>  
> +#if IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
>  module_param_named(probe_display, xe_modparam.probe_display, bool, 0444);
>  MODULE_PARM_DESC(probe_display, "Probe display HW, otherwise it's left untouched "
>  		 "[default=" __stringify(XE_DEFAULT_PROBE_DISPLAY) "])");
> +#endif
>  
>  module_param_named(vram_bar_size, xe_modparam.force_vram_bar_size, int, 0600);
>  MODULE_PARM_DESC(vram_bar_size, "Set the vram bar size in MiB (<0=disable-resize, 0=max-needed-size, >0=force-size "
> -- 
> 2.47.1
>