intel-xe.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] drm/i915/backlight: Fix divide by 0 error in i9xx_set_backlight
@ 2025-08-19 16:04 Suraj Kandpal
  2025-08-20  1:17 ` ✓ CI.KUnit: success for drm/i915/backlight: Fix divide by 0 error in i9xx_set_backlight (rev2) Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Suraj Kandpal @ 2025-08-19 16:04 UTC (permalink / raw)
  To: intel-xe, intel-gfx; +Cc: jouni.hogander, jani.nikula, Suraj Kandpal

pwm_level_max maybe 0 we do throw a warning but move ahead with
execution which may later cause a /0 error.

--v2
-return if the warn_on gets hit [Jani]

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_backlight.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c
index e007380e9a63..3b14f929825a 100644
--- a/drivers/gpu/drm/i915/display/intel_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_backlight.c
@@ -236,7 +236,8 @@ static void i9xx_set_backlight(const struct drm_connector_state *conn_state, u32
 	struct intel_panel *panel = &connector->panel;
 	u32 tmp, mask;
 
-	drm_WARN_ON(display->drm, panel->backlight.pwm_level_max == 0);
+	if (drm_WARN_ON(display->drm, panel->backlight.pwm_level_max == 0))
+		return;
 
 	if (panel->backlight.combination_mode) {
 		struct pci_dev *pdev = to_pci_dev(display->drm->dev);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-08-20 23:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-19 16:04 [PATCH v2] drm/i915/backlight: Fix divide by 0 error in i9xx_set_backlight Suraj Kandpal
2025-08-20  1:17 ` ✓ CI.KUnit: success for drm/i915/backlight: Fix divide by 0 error in i9xx_set_backlight (rev2) Patchwork
2025-08-20  2:40 ` ✓ Xe.CI.BAT: " Patchwork
2025-08-20  7:18 ` [PATCH v2] drm/i915/backlight: Fix divide by 0 error in i9xx_set_backlight Jani Nikula
2025-08-20 23:05 ` ✗ Xe.CI.Full: failure for drm/i915/backlight: Fix divide by 0 error in i9xx_set_backlight (rev2) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).