Re: [PATCH 3/3] drm/xe/gt_pagefault: Change vma_pagefault unit to kilobyte

[Matthew Auld <matthew.auld@intel.com>]

On 25/02/2025 13:17, Francois Dugast wrote:
> Increase the amount of bytes that can be counted before the counter
> overflows, while not losing information as the VMA is not expected
> to have sub-kilobyte size.
> 
> Suggested-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Francois Dugast <francois.dugast@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_gt_pagefault.c   | 2 +-
>   drivers/gpu/drm/xe/xe_gt_stats.c       | 2 +-
>   drivers/gpu/drm/xe/xe_gt_stats_types.h | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_pagefault.c b/drivers/gpu/drm/xe/xe_gt_pagefault.c
> index 46701ca11ce0..17d69039b866 100644
> --- a/drivers/gpu/drm/xe/xe_gt_pagefault.c
> +++ b/drivers/gpu/drm/xe/xe_gt_pagefault.c
> @@ -137,7 +137,7 @@ static int handle_vma_pagefault(struct xe_gt *gt, struct pagefault *pf,
>   	bool atomic;
>   
>   	xe_gt_stats_incr(gt, XE_GT_STATS_ID_VMA_PAGEFAULT_COUNT, 1);
> -	xe_gt_stats_incr(gt, XE_GT_STATS_ID_VMA_PAGEFAULT_BYTES, xe_vma_size(vma));
> +	xe_gt_stats_incr(gt, XE_GT_STATS_ID_VMA_PAGEFAULT_KB, xe_vma_size(vma) / 1024);

Not sure if this will throw a build error on 32b?

Reviewed-by: Matthew Auld <matthew.auld@intel.com>

>   
>   	trace_xe_vma_pagefault(vma);
>   	atomic = access_is_atomic(pf->access_type);
> diff --git a/drivers/gpu/drm/xe/xe_gt_stats.c b/drivers/gpu/drm/xe/xe_gt_stats.c
> index 83de2ec92fdc..50a1636773d8 100644
> --- a/drivers/gpu/drm/xe/xe_gt_stats.c
> +++ b/drivers/gpu/drm/xe/xe_gt_stats.c
> @@ -14,7 +14,7 @@
>   static const char *const stat_description[__XE_GT_STATS_NUM_IDS] = {
>   	"tlb_inval_count",
>   	"vma_pagefault_count",
> -	"vma_pagefault_bytes",
> +	"vma_pagefault_kb",
>   };
>   
>   /**
> diff --git a/drivers/gpu/drm/xe/xe_gt_stats_types.h b/drivers/gpu/drm/xe/xe_gt_stats_types.h
> index b072bd80c4b9..d556771f99d6 100644
> --- a/drivers/gpu/drm/xe/xe_gt_stats_types.h
> +++ b/drivers/gpu/drm/xe/xe_gt_stats_types.h
> @@ -9,7 +9,7 @@
>   enum xe_gt_stats_id {
>   	XE_GT_STATS_ID_TLB_INVAL,
>   	XE_GT_STATS_ID_VMA_PAGEFAULT_COUNT,
> -	XE_GT_STATS_ID_VMA_PAGEFAULT_BYTES,
> +	XE_GT_STATS_ID_VMA_PAGEFAULT_KB,
>   	/* must be the last entry */
>   	__XE_GT_STATS_NUM_IDS,
>   };