Re: [PATCH 05/14] include/drm/display/dp: Add field for storing AS SDP version

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, Feb 23, 2026 at 07:14:22PM +0530, Ankit Nautiyal wrote:
> Add a new member to store Adaptive Sync SDP version and include it in AS
> SDP logs.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>  drivers/gpu/drm/display/drm_dp_helper.c | 1 +
>  include/drm/display/drm_dp_helper.h     | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
> index a697cc227e28..9469943d8194 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -3507,6 +3507,7 @@ void drm_dp_as_sdp_log(struct drm_printer *p, const struct drm_dp_as_sdp *as_sdp
>  {
>  	drm_printf(p, "DP SDP: AS_SDP, revision %u, length %u\n",
>  		   as_sdp->revision, as_sdp->length);
> +	drm_printf(p, "    version: %d\n", as_sdp->version);
>  	drm_printf(p, "    vtotal: %d\n", as_sdp->vtotal);
>  	drm_printf(p, "    target_rr: %d\n", as_sdp->target_rr);
>  	drm_printf(p, "    duration_incr_ms: %d\n", as_sdp->duration_incr_ms);
> diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h
> index 1d0acd58f486..c71787fc31c1 100644
> --- a/include/drm/display/drm_dp_helper.h
> +++ b/include/drm/display/drm_dp_helper.h
> @@ -120,6 +120,7 @@ struct drm_dp_as_sdp {
>  	unsigned char sdp_type;
>  	unsigned char revision;
                      ^^^^^^^^

Isn't that already the thing you're trying to add here?

>  	unsigned char length;
> +	int version;
>  	int vtotal;
>  	int target_rr;
>  	int duration_incr_ms;
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel