From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85B15FD8FCA for ; Thu, 26 Feb 2026 16:01:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 214B910E96B; Thu, 26 Feb 2026 16:01:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="C+UkJd+S"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD89010E96B; Thu, 26 Feb 2026 16:01:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772121704; x=1803657704; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=OXZTjtKi5Ik0F9eC4rQ7zdeMg+KRBCgLFvprHIU5r2s=; b=C+UkJd+Sh++BFthgXtwN1Gop5Kno4/LLi34EhxGkq4+lb0+YaWnFDKS3 srIuwry0II45VPsNerk5yVXI6ZEarmDErw4sIQszNPeygTodR07UfZlY4 lLgbhB62KDyFeRQ3YvVPDMNLMMRD7Nn7cCA0kT+kSlKjGmrkPQLyEX2GQ XHslRR2F6zkWwAVeB/uujsgaixxVmtD/jmJdrf77tXPMkR2QfyGC9uUkx GxFzNq0mtG0Gh7gIFvp9H6kKs4Hz8JM5K9qkA2yRAnZ2GNKSbG82eKywi RWJNXHLSYskNrVpSUUPJK570/YC9Tmv77lFJjJxTIXwTIQwxpxzs54zLE w==; X-CSE-ConnectionGUID: keZnR66rRvOufYQI4/L+qg== X-CSE-MsgGUID: Xl7x6MSkT7ShZZ29/zt7Xw== X-IronPort-AV: E=McAfee;i="6800,10657,11713"; a="84281065" X-IronPort-AV: E=Sophos;i="6.21,312,1763452800"; d="scan'208";a="84281065" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2026 08:01:44 -0800 X-CSE-ConnectionGUID: 7egNvZwoTKuIhi4PweLE/Q== X-CSE-MsgGUID: rT5S4tFhTOGB3wvMTctfXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,312,1763452800"; d="scan'208";a="254376493" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.244.224]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2026 08:01:41 -0800 Date: Thu, 26 Feb 2026 18:01:38 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Ankit Nautiyal Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, jouni.hogander@intel.com, animesh.manna@intel.com Subject: Re: [PATCH 03/14] drm/i915/dp: Add a helper to decide if AS SDP is needed Message-ID: References: <20260223134431.1639308-1-ankit.k.nautiyal@intel.com> <20260223134431.1639308-4-ankit.k.nautiyal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, Feb 26, 2026 at 05:29:48PM +0200, Ville Syrjälä wrote: > On Mon, Feb 23, 2026 at 07:14:20PM +0530, Ankit Nautiyal wrote: > > Add a helper to check if AS SDP is needed. Currently AS SDP is only > > required when VRR is enabled. However, there are other use cases, along > > with the missing case of CMRR, dealt in subsequent changes. > > > > Signed-off-by: Ankit Nautiyal > > --- > > drivers/gpu/drm/i915/display/intel_dp.c | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > > index b999d8c085c7..65764ab0bb9b 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > @@ -3111,6 +3111,12 @@ static void intel_dp_compute_vsc_colorimetry(const struct intel_crtc_state *crtc > > vsc->content_type = DP_CONTENT_TYPE_NOT_DEFINED; > > } > > > > +static bool intel_dp_needs_as_sdp(struct intel_dp *intel_dp, > > + struct intel_crtc_state *crtc_state) > > +{ > > + return crtc_state->vrr.enable; > > Since we don't support VRR+PCON I don't think we actually > need the AS SDP for VRR. Hmm. DP 2.1a does say "When the plugged DP device has DPCD 02214h[0] = 1, a DP Source device shall transmit an Adaptive-Sync SDP before enabling an Adaptive-Sync video transmission." So maybe we do need to transmit it whenever the DP device supports it. In that case someone will probably need to figure out the fastset stuff. > > And I don't think we even have a fastset path for this stuff > (or where is it?) so isn't this already causing fastset > failures for VRR enable/disable? Or maybe we don't have > displays with both VRR and AS SDP support anywhere? > > > +} > > + > > static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp, > > struct intel_crtc_state *crtc_state) > > { > > @@ -3118,7 +3124,10 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp, > > const struct drm_display_mode *adjusted_mode = > > &crtc_state->hw.adjusted_mode; > > > > - if (!crtc_state->vrr.enable || !intel_dp->as_sdp_supported) > > + if (!intel_dp->as_sdp_supported) > > + return; > > + > > + if (!intel_dp_needs_as_sdp(intel_dp, crtc_state)) > > return; > > > > crtc_state->infoframes.enable |= intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC); > > -- > > 2.45.2 > > -- > Ville Syrjälä > Intel -- Ville Syrjälä Intel