From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED451FD8FD3 for ; Thu, 26 Feb 2026 16:12:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 94BD910E9AB; Thu, 26 Feb 2026 16:12:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ZixFBDFt"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0C02310E9A9; Thu, 26 Feb 2026 16:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772122360; x=1803658360; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Nz492zzl5jdehZEwE1hU3FqEZ4iIC0pchqOfGVv2WVg=; b=ZixFBDFtjfm4QcVf4bCkgmSfVhY7jGD4YU/tiltav/d9i4mylEdPrI8n FNTK/XlZYValqgbNOSX+uDlTrinPk4xobukwXi5oVZ9Kw5TiPcv+6xi/g Z7xBiozOqoZapRsyv6CJar4ws/UdQDu7BRbdxJwYbTnVetZUNq+AcMG5n kfR6RPqWjFzMwK7mRea+UG6bT2o+XdMEt4lDEkF54tZ6WHvEYwU6nN9SJ Xdprj0AmAlgnfalBXIRYSPftsemYD42Qh0lpyq64ZhEgK31KAhhvuJXbz CPn34wrvA00KdyDjuCRMJ3SvfhX0StbRdspfoo1y3MWzrqyu2prPKwhVB Q==; X-CSE-ConnectionGUID: U6Tn5b4HRWiy95bxJQem7Q== X-CSE-MsgGUID: roS4ieV3QCqG5S7bv7h6FA== X-IronPort-AV: E=McAfee;i="6800,10657,11713"; a="83823168" X-IronPort-AV: E=Sophos;i="6.21,312,1763452800"; d="scan'208";a="83823168" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2026 08:12:40 -0800 X-CSE-ConnectionGUID: OcN3r6hJRNCD+HjvDCJOyg== X-CSE-MsgGUID: xvPbkbv0TZmT59g+4xzTFA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,312,1763452800"; d="scan'208";a="215733142" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO localhost) ([10.245.244.224]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2026 08:12:37 -0800 Date: Thu, 26 Feb 2026 18:12:33 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Ankit Nautiyal Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, jouni.hogander@intel.com, animesh.manna@intel.com Subject: Re: [PATCH 09/14] drm/i915/psr: Add helper to check if PR is with link OFF Message-ID: References: <20260223134431.1639308-1-ankit.k.nautiyal@intel.com> <20260223134431.1639308-10-ankit.k.nautiyal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260223134431.1639308-10-ankit.k.nautiyal@intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, Feb 23, 2026 at 07:14:26PM +0530, Ankit Nautiyal wrote: > Introduce a helper intel_psr_is_pr_with_link_off() to check if the Panel > Replay feature needs to be enabled with link off. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_psr.c | 6 ++++++ > drivers/gpu/drm/i915/display/intel_psr.h | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c > index 5bea2eda744b..e0e6ddbfaa2d 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -4575,3 +4575,9 @@ bool intel_psr_use_trans_push(const struct intel_crtc_state *crtc_state) > > return HAS_PSR_TRANS_PUSH_FRAME_CHANGE(display) && crtc_state->has_psr; > } > + > +bool intel_psr_is_pr_with_link_off(const struct intel_crtc_state *crtc_state) > +{ > + return crtc_state->has_panel_replay && > + crtc_state->link_off_after_as_sdp_when_pr_active; I don't think that flag has anything to do with what you're trying to determine here. > +} > diff --git a/drivers/gpu/drm/i915/display/intel_psr.h b/drivers/gpu/drm/i915/display/intel_psr.h > index 394b641840b3..6764bcb13f9b 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.h > +++ b/drivers/gpu/drm/i915/display/intel_psr.h > @@ -86,5 +86,6 @@ void intel_psr_compute_config_late(struct intel_dp *intel_dp, > struct intel_crtc_state *crtc_state); > int intel_psr_min_guardband(struct intel_crtc_state *crtc_state); > bool intel_psr_use_trans_push(const struct intel_crtc_state *crtc_state); > +bool intel_psr_is_pr_with_link_off(const struct intel_crtc_state *crtc_state); > > #endif /* __INTEL_PSR_H__ */ > -- > 2.45.2 -- Ville Syrjälä Intel