From: Matthew Brost <matthew.brost@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: intel-xe@lists.freedesktop.org,
"Matthew Auld" <matthew.auld@intel.com>,
"Christian König" <christian.koenig@amd.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/ttm: Don't spam the log on buffer object backing store allocation failure
Date: Fri, 27 Feb 2026 13:01:46 -0800 [thread overview]
Message-ID: <aaIGOqOD5ti5W5v1@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20260227160012.82309-2-thomas.hellstrom@linux.intel.com>
On Fri, Feb 27, 2026 at 05:00:11PM +0100, Thomas Hellström wrote:
> If the struct ttm_operation_ctx::gfp_retry_mayfail is true,
> buffer object backing store allocation failures are expected to
> silently fail with an error code to the caller. But currently an
> elaborate warning is printed to the system log.
>
> Don't spam the log in this way.
>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/ttm/ttm_pool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c
> index c0d95559197c..8fa9e09f6ee5 100644
> --- a/drivers/gpu/drm/ttm/ttm_pool.c
> +++ b/drivers/gpu/drm/ttm/ttm_pool.c
> @@ -726,7 +726,7 @@ static int __ttm_pool_alloc(struct ttm_pool *pool, struct ttm_tt *tt,
> gfp_flags |= __GFP_ZERO;
>
> if (ctx->gfp_retry_mayfail)
> - gfp_flags |= __GFP_RETRY_MAYFAIL;
> + gfp_flags |= __GFP_RETRY_MAYFAIL | __GFP_NOWARN;
>
> if (ttm_pool_uses_dma32(pool))
> gfp_flags |= GFP_DMA32;
> --
> 2.53.0
>
next prev parent reply other threads:[~2026-02-27 21:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 16:00 [PATCH 0/2] drm/ttm: Improve the TTM operation context gfp_retry_mayfail behaviour Thomas Hellström
2026-02-27 16:00 ` [PATCH 1/2] drm/ttm: Don't spam the log on buffer object backing store allocation failure Thomas Hellström
2026-02-27 21:01 ` Matthew Brost [this message]
2026-03-02 9:02 ` Christian König
2026-03-02 9:39 ` Thomas Hellström
2026-03-09 9:36 ` Simona Vetter
2026-02-27 16:00 ` [PATCH 2/2] drm/ttm: Avoid invoking the OOM killer when reading back swapped content Thomas Hellström
2026-03-10 14:10 ` Maarten Lankhorst
2026-02-27 17:06 ` ✓ CI.KUnit: success for drm/ttm: Improve the TTM operation context gfp_retry_mayfail behaviour Patchwork
2026-02-27 17:59 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-28 3:48 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaIGOqOD5ti5W5v1@lstrano-desk.jf.intel.com \
--to=matthew.brost@intel.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox