Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <rodrigo.vivi@intel.com>,
	<riana.tauro@intel.com>, <michal.wajdeczko@intel.com>,
	<matthew.d.roper@intel.com>, <lukasz.laguna@intel.com>
Subject: Re: [PATCH v1] drm/xe/guc_submit: Log wedged mode correctly
Date: Sun, 1 Mar 2026 20:40:37 -0800	[thread overview]
Message-ID: <aaUUxT84WtDEYfJe@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20260228190524.3471743-1-raag.jadav@intel.com>

On Sun, Mar 01, 2026 at 12:35:02AM +0530, Raag Jadav wrote:
> The device can be declared wedged in basically any wedged mode. Log the
> correct one that is set in device struct instead of hardcoding it.
> 
> Fixes: 17d3c3365ba9 ("drm/xe: Validate wedged_mode parameter and define enum for modes")
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index de716c1fb18e..4c761087c830 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1319,7 +1319,7 @@ void xe_guc_submit_wedge(struct xe_guc *guc)
>  	if (err) {
>  		xe_gt_err(gt, "Failed to register clean-up in wedged.mode=%s; "
>  			  "Although device is wedged.\n",
> -			  xe_wedged_mode_to_string(XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET));
> +			  xe_wedged_mode_to_string(guc_to_xe(guc)->wedged.mode));

It is actually a bug to register this in any mode aside from
XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET. We have a patch / series floating
around to fix this [1].

Matt

[1] https://patchwork.freedesktop.org/patch/706751/?series=162074&rev=2

>  		return;
>  	}
>  
> -- 
> 2.43.0
> 

      parent reply	other threads:[~2026-03-02  4:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28 19:05 [PATCH v1] drm/xe/guc_submit: Log wedged mode correctly Raag Jadav
2026-02-28 19:15 ` ✓ CI.KUnit: success for " Patchwork
2026-02-28 19:58 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-28 21:00 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-02  4:40 ` Matthew Brost [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaUUxT84WtDEYfJe@lstrano-desk.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lukasz.laguna@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox