Re: [PATCH v2 08/11] drm/xe/xe_ras: Add support for Uncorrectable Core-Compute errors

Raag Jadav
2026-03-06T18:37:11Z

On Wed, Mar 04, 2026 at 05:52:38PM +0100, Raag Jadav wrote:
> On Mon, Mar 02, 2026 at 03:52:03PM +0530, Riana Tauro wrote:
> > Uncorrectable Core-Compute errors are classified into Global and Local
> > errors.
> >
> > Global error is an error that affects the entire device requiring a
> > reset. This type of error is not isolated. When an AER is reported and
> > error_detected is invoked return PCI_ERS_RESULT_NEED_RESET.
> >
> > A Local error is confined to a specific component or context like a
> > engine. These errors can be contained and recovered by resetting
> > only the affected part without distrupting the rest of the device.
> >
> > Upon detection of an Uncorrectable Local Core-Compute error, an AER is
> > generated and GuC is notified of the error. The KMD then sets
> > the context as non-runnable and initiates an engine reset.
> > (TODO: GuC <->KMD communication for the error).

...

> > + } while (response.additional_errors);
>
> I know we're not NASA but I'd try to have some timeout instead of blindly
> trusting the hardware.

Or just break on something like MAX_ADDITIONAL_ERRORS if (by any luck)
it's mentioned in spec.

Raag