Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-xe@lists.freedesktop.org,
	Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Subject: Re: [PATCH 3/3] drm/xe/vf: Don't expose privileged GT debugfs files if VF
Date: Wed, 2 Apr 2025 21:27:31 +0200	[thread overview]
Message-ID: <ab19b061-4b80-4acb-82f1-0311da276d26@intel.com> (raw)
In-Reply-To: <fvnsx2rcjljjlwdb2sjxqo3otzpffnfs666ueldgojsb5o5gqd@xxpmrvvmnisi>



On 21.03.2025 17:55, Lucas De Marchi wrote:
> On Thu, Mar 20, 2025 at 10:07:38PM +0100, Michal Wajdeczko wrote:

...

> 
> Another possible idea: would it make sense to add a flag in
> drm.driver_features to note if the driver if pf/vf? That way we may
> simplify other places and then here we could just do:
> 
>     { {"steering", .show = xe_gt_debugfs_simple_show, .data = steering,
>        .driver_features = DRIVER_SRIOV_PF },
>        ...
>     }
> 
> instead of splitting the array.

tempting idea, but I'm not sure how/when this could be accepted at drm
level, and whether our single static drm_driver instance will survive
both PF and VFs instances at the same time

> 
> pass by comment since I was involved in other threads related to default
> context in PTL... Are these default_lrc_* accurate from the VF point of
> view? Are they different from the ones for PF?

it should reflect what VF uses and it should be the same as on PF


  reply	other threads:[~2025-04-02 19:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 21:07 [PATCH 0/3] VF: debugfs fixes Michal Wajdeczko
2025-03-20 21:07 ` [PATCH 1/3] drm/xe/guc: Refactor GuC debugfs initialization Michal Wajdeczko
2025-03-21 16:37   ` Lucas De Marchi
2025-03-20 21:07 ` [PATCH 2/3] drm/xe/guc: Don't expose GuC privileged debugfs files if VF Michal Wajdeczko
2025-03-21 16:38   ` Lucas De Marchi
2025-03-20 21:07 ` [PATCH 3/3] drm/xe/vf: Don't expose privileged GT " Michal Wajdeczko
2025-03-21 16:55   ` Lucas De Marchi
2025-04-02 19:27     ` Michal Wajdeczko [this message]
2025-03-20 21:12 ` ✓ CI.Patch_applied: success for VF: debugfs fixes Patchwork
2025-03-20 21:12 ` ✓ CI.checkpatch: " Patchwork
2025-03-20 21:13 ` ✓ CI.KUnit: " Patchwork
2025-03-20 21:30 ` ✓ CI.Build: " Patchwork
2025-03-20 21:36 ` ✓ CI.Hooks: " Patchwork
2025-03-20 21:37 ` ✓ CI.checksparse: " Patchwork
2025-03-20 21:56 ` ✓ Xe.CI.BAT: " Patchwork
2025-03-20 23:20 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab19b061-4b80-4acb-82f1-0311da276d26@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=marcin.bernatowicz@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox