public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/backlight: Fix VESA backlight possible check condition
@ 2026-04-01  3:43 Suraj Kandpal
  2026-04-01  3:50 ` ✓ CI.KUnit: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Suraj Kandpal @ 2026-04-01  3:43 UTC (permalink / raw)
  To: intel-xe, intel-gfx; +Cc: ankit.k.nautiyal, ville.syrjala, Suraj Kandpal

VESA backlight is possible through AUX only when
BACKLIGHT_AUX_ENABLE_CAPABLE is true or when we use BL_ENABLE bit
to enable backlight. Since that is not implemented we need to make
sure we do not try to manipulate backlight when
BACKLIGHT_AUX_ENABLE_CAPABLE is not set.
Also fix return value when condition is not fulfilled.

Fixes: 40d2f5820951 ("drm/i915/backlight: Remove try_vesa_interface")
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index d0c76632a946..138d5b5e5482 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -615,8 +615,9 @@ check_if_vesa_backlight_possible(struct intel_dp *intel_dp)
 	int ret;
 	u8 bit_min, bit_max;
 
-	if (!(intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP))
-		return true;
+	if (!(intel_dp->edp_dpcd[2] & DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP &&
+	      intel_dp->edp_dpcd[1] & DP_EDP_BACKLIGHT_AUX_ENABLE_CAP))
+		return false;
 
 	ret = drm_dp_dpcd_read_byte(&intel_dp->aux, DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN, &bit_min);
 	if (ret < 0)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-04-07 11:10 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-01  3:43 [PATCH] drm/i915/backlight: Fix VESA backlight possible check condition Suraj Kandpal
2026-04-01  3:50 ` ✓ CI.KUnit: success for " Patchwork
2026-04-01  4:36 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-01 10:53 ` ✓ Xe.CI.FULL: " Patchwork
2026-04-02 19:18 ` [PATCH] " Ville Syrjälä
2026-04-06 14:42 ` Nautiyal, Ankit K
2026-04-07  3:07 ` [PATCH v2] " Suraj Kandpal
2026-04-07 11:10   ` Nautiyal, Ankit K
2026-04-07  4:30 ` ✓ CI.KUnit: success for drm/i915/backlight: Fix VESA backlight possible check condition (rev2) Patchwork
2026-04-07  5:07 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-07  6:39 ` ✗ Xe.CI.FULL: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox