From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0A69105F78C for ; Fri, 13 Mar 2026 11:57:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7EA9910EBBC; Fri, 13 Mar 2026 11:57:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Pkx3Daur"; dkim-atps=neutral Received: from mgamail.intel.com (unknown [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C02A10EBBC for ; Fri, 13 Mar 2026 11:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773403039; x=1804939039; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=LOnaTDGC51VgqbQ1maJ7Rj1bBIfxNyBbFiCTiX4kJkU=; b=Pkx3DaurHZynA0gB2tHcQ6GEnq4Jhn14nHsOaVo2b9P5b52KVskD3dzo eHWRc872psdVDpuN2GQ2aJ4qTw3XEnx80snGwAeOzF8Yuso9Qi5qLhXSs zWOdi/XGmH04j23C25VIqmW8XaE1dz17/X0Cx32xdLg0R+d/YFjaVBaix mCzZcopK81ox0orYvMQE9RGHlrzLdRFKaWgXnbeLuuYZAjiLr0TnV6FW4 MCgXXQbU8x0sWrTFzV2SByTpP8f6dW+RaDWXjkv1oeCKUsc5AyHk3dTzK OPDd+UzuhG6d5b5iFU4fvAY8YuamYgV6CJrk6LLLo08thMgOfbAhQAf17 Q==; X-CSE-ConnectionGUID: vrMqpdkPQhudpzyIZE6now== X-CSE-MsgGUID: R8vZt/rxReGSNiRkPeRRwA== X-IronPort-AV: E=McAfee;i="6800,10657,11727"; a="78106891" X-IronPort-AV: E=Sophos;i="6.23,118,1770624000"; d="scan'208";a="78106891" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2026 04:55:31 -0700 X-CSE-ConnectionGUID: hPfhKbCCQgeKFntlc8En4w== X-CSE-MsgGUID: +FaFAoLxT5iJZKLp6UhaFg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,118,1770624000"; d="scan'208";a="225602127" Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.21]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2026 04:55:29 -0700 Date: Fri, 13 Mar 2026 13:55:26 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Ankit Nautiyal Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, jouni.hogander@intel.com, animesh.manna@intel.com Subject: Re: [PATCH 10/19] drm/i915/dp: Use revision field of AS SDP data structure Message-ID: References: <20260311113611.3393194-1-ankit.k.nautiyal@intel.com> <20260311113611.3393194-11-ankit.k.nautiyal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260311113611.3393194-11-ankit.k.nautiyal@intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, Mar 11, 2026 at 05:06:02PM +0530, Ankit Nautiyal wrote: > Use the revision field of struct drm_dp_as_sdp instead of current > hardcoding for the AS SDP revisions. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_display.c | 3 ++- > drivers/gpu/drm/i915/display/intel_dp.c | 7 +++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index b18ce0c36a64..88e1b503d301 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -4900,7 +4900,8 @@ static bool > intel_compare_dp_as_sdp(const struct drm_dp_as_sdp *a, > const struct drm_dp_as_sdp *b) > { > - return a->vtotal == b->vtotal && > + return a->revision == b->revision && Someone should add the check for the type and length as well (and other relevant stuff in the header if any). But that can be a separate patch. Reviewed-by: Ville Syrjälä > + a->vtotal == b->vtotal && > a->target_rr == b->target_rr && > a->duration_incr_ms == b->duration_incr_ms && > a->duration_decr_ms == b->duration_decr_ms && > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 17af68a1a9e5..0d2403d48528 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -3154,6 +3154,7 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp, > as_sdp->sdp_type = DP_SDP_ADAPTIVE_SYNC; > as_sdp->length = 0x9; > as_sdp->duration_incr_ms = 0; > + as_sdp->revision = 0x2; > as_sdp->vtotal = intel_vrr_vmin_vtotal(crtc_state); > > if (crtc_state->cmrr.enable) { > @@ -5117,7 +5118,7 @@ static ssize_t intel_dp_as_sdp_pack(const struct drm_dp_as_sdp *as_sdp, > /* Prepare AS (Adaptive Sync) SDP Header */ > sdp->sdp_header.HB0 = 0; > sdp->sdp_header.HB1 = as_sdp->sdp_type; > - sdp->sdp_header.HB2 = 0x02; > + sdp->sdp_header.HB2 = as_sdp->revision; > sdp->sdp_header.HB3 = as_sdp->length; > > /* Fill AS (Adaptive Sync) SDP Payload */ > @@ -5304,13 +5305,11 @@ int intel_dp_as_sdp_unpack(struct drm_dp_as_sdp *as_sdp, > if (sdp->sdp_header.HB1 != DP_SDP_ADAPTIVE_SYNC) > return -EINVAL; > > - if (sdp->sdp_header.HB2 != 0x02) > - return -EINVAL; > - > if ((sdp->sdp_header.HB3 & 0x3F) != 9) > return -EINVAL; > > as_sdp->length = sdp->sdp_header.HB3 & DP_AS_SDP_LENGTH_MASK; > + as_sdp->revision = sdp->sdp_header.HB2; > as_sdp->mode = sdp->db[0] & DP_AS_SDP_OPERATION_MODE_MASK; > as_sdp->vtotal = (sdp->db[2] << 8) | sdp->db[1]; > as_sdp->target_rr = ((sdp->db[4] & 0x3) << 8) | sdp->db[3]; > -- > 2.45.2 -- Ville Syrjälä Intel