From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12027105F7A4 for ; Fri, 13 Mar 2026 12:40:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 45C3310EBD9; Fri, 13 Mar 2026 12:40:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="du6wncPk"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id ADCF210EB91; Fri, 13 Mar 2026 12:40:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773405620; x=1804941620; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=lftuJTRKnc5D/QCh34HBglTEbNopnnHKYQJjTxnUxUY=; b=du6wncPkpqNEKSxNRBeVhr8kWaYFEFNsr2mpM1/4GFCM+I0uOVbDjySD VUzHKqGnFniiSr+qTr0Ow3FTLCYBKM4F3FKkJ7f4XTZy1U+29wnwCEAHR U/dvfkHWh78q49s0lNF7I4jp/PmIVAtDt+tsM25/ecJEqKryZytU2YOq+ F0ztRByz0qIAVOTp8I0y5bo3vFviprbct6MYXdthB2adMhtWrOJvtOiDi sfWPfiv01EgRbRpbEngHr/WIxyva4IbjNyPf5TduKyldpeBMfajagKHwv ykbsAXtXytw8Sjch4TsiBOUtCilP9A+7ndNmUd8GIleJgyCfqU5L/0lvg w==; X-CSE-ConnectionGUID: 01rXmuyNQuSnavDAo6GJ2w== X-CSE-MsgGUID: dkUT+NTmQSKI5AFYhxOwog== X-IronPort-AV: E=McAfee;i="6800,10657,11727"; a="78361951" X-IronPort-AV: E=Sophos;i="6.23,118,1770624000"; d="scan'208";a="78361951" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2026 05:40:19 -0700 X-CSE-ConnectionGUID: fpI1WfLQS2SJ5BrTjVNvSA== X-CSE-MsgGUID: TB012AUhTKig6UBarvJNCg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,118,1770624000"; d="scan'208";a="216068206" Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.21]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2026 05:40:17 -0700 Date: Fri, 13 Mar 2026 14:40:14 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Ankit Nautiyal Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, jouni.hogander@intel.com, animesh.manna@intel.com Subject: Re: [PATCH 16/19] drm/i915/dp: Program AS SDP DB[1:0] for PR with Link off Message-ID: References: <20260311113611.3393194-1-ankit.k.nautiyal@intel.com> <20260311113611.3393194-17-ankit.k.nautiyal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260311113611.3393194-17-ankit.k.nautiyal@intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, Mar 11, 2026 at 05:06:08PM +0530, Ankit Nautiyal wrote: > For Panel Replay with AUX-less ALPM (link-off PR), the source must send > Adaptive-Sync SDP v2. Program DB[1:0] per DP spec v2.1: > - VRR AVT: 00b (variable VTotal) > - VRR FAVT: 10b/11b (TRR not reached/reached) > - Fixed timing with PR link-off (VRR off): 01b (AS disabled; VTotal fixed) > > Also, drop the redundant target_rr assignment. > > v2: Fix the else case. (Ville) > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 74a8af3cf18c..2b0318e0ceb0 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -3161,9 +3161,10 @@ static void intel_dp_compute_as_sdp(struct intel_dp *intel_dp, > as_sdp->mode = DP_AS_SDP_FAVT_TRR_REACHED; > as_sdp->target_rr = drm_mode_vrefresh(adjusted_mode); > as_sdp->target_rr_divider = true; > - } else { > + } else if (crtc_state->vrr.enable) { Due to the lack of fastset for this we pretty much need a s/crtc_state->vrr.enable/vrr_possible()/ pass over everything. But for now this is at least more correct than the current thing, so Reviewed-by: Ville Syrjälä > as_sdp->mode = DP_AS_SDP_AVT_DYNAMIC_VTOTAL; > - as_sdp->target_rr = 0; > + } else { > + as_sdp->mode = DP_AS_SDP_AVT_FIXED_VTOTAL; > } > } > > -- > 2.45.2 -- Ville Syrjälä Intel