Re: [PATCH v3 04/25] drm/xe: Add job count to GuC exec queue snapshot

Summers, Stuart
2026-03-02T20:50:57Z

On Fri, 2026-02-27 at 17:34 -0800, Matthew Brost wrote:
> Add the job count to the GuC exec queue snapshot, as this is useful
> debug information.
>
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Stuart Summers <stuart.summers@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c       | 2 ++
>  drivers/gpu/drm/xe/xe_guc_submit_types.h | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c
> b/drivers/gpu/drm/xe/xe_guc_submit.c
> index ca7aa4f358d0..453af51fe87b 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -3207,6 +3207,7 @@ xe_guc_exec_queue_snapshot_capture(struct
> xe_exec_queue *q)
>         snapshot->logical_mask = q->logical_mask;
>         snapshot->width = q->width;
>         snapshot->refcount = kref_read(&q->refcount);
> +       snapshot->jobcount = atomic_read(&q->job_cnt);
>         snapshot->sched_timeout = sched->base.timeout;
>         snapshot->sched_props.timeslice_us = q-
> >sched_props.timeslice_us;
>         snapshot->sched_props.preempt_timeout_us =
> @@ -3279,6 +3280,7 @@ xe_guc_exec_queue_snapshot_print(struct
> xe_guc_submit_exec_queue_snapshot *snaps
>         drm_printf(p, "\tLogical mask: 0x%x\n", snapshot-
> >logical_mask);
>         drm_printf(p, "\tWidth: %d\n", snapshot->width);
>         drm_printf(p, "\tRef: %d\n", snapshot->refcount);
> +       drm_printf(p, "\tJob count: %d\n", snapshot->jobcount);
>         drm_printf(p, "\tTimeout: %ld (ms)\n", snapshot-
> >sched_timeout);
>         drm_printf(p, "\tTimeslice: %u (us)\n",
>                    snapshot->sched_props.timeslice_us);
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit_types.h
> b/drivers/gpu/drm/xe/xe_guc_submit_types.h
> index 5ccc5f959bb3..529d4b1f83fc 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit_types.h
> +++ b/drivers/gpu/drm/xe/xe_guc_submit_types.h
> @@ -77,6 +77,8 @@ struct xe_guc_submit_exec_queue_snapshot {
>         u16 width;
>         /** @refcount: ref count of this exec queue */
>         u32 refcount;
> +       /** @jobcount: job count of this exec queue */
> +       u32 jobcount;
>         /**
>          * @sched_timeout: the time after which a job is removed from
> the
>          * scheduler.