Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: John Harrison <john.c.harrison@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: <Intel-Xe@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/xe/guc: Reduce default GuC log verbosity
Date: Fri, 8 Nov 2024 15:49:04 -0800	[thread overview]
Message-ID: <ac48a2e3-6ab6-4518-85ad-0f696e09bebc@intel.com> (raw)
In-Reply-To: <Zy6f16+PhbgxZYTb@lstrano-desk.jf.intel.com>

On 11/8/2024 15:33, Matthew Brost wrote:
> On Fri, Nov 08, 2024 at 01:27:36PM -0800, John.C.Harrison@Intel.com wrote:
>> From: John Harrison <John.C.Harrison@Intel.com>
>>
>> Drop the default verbosity from 5 (max) to 3 as the extra verbosity
>> generally doesn't provide anything vitally important but does cause
>> rapid log overflow.
>>
> We still get the H2G, G2H, scheduling information and CSBs at this
> level, right? That generally what we care about.
Yes. Including full parameters for H2G/G2H.

John.

>
> Assuming the above is true:
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
>
>> Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_module.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_module.c b/drivers/gpu/drm/xe/xe_module.c
>> index 77ce9f9ca7a5..0f2c20e9204a 100644
>> --- a/drivers/gpu/drm/xe/xe_module.c
>> +++ b/drivers/gpu/drm/xe/xe_module.c
>> @@ -19,7 +19,7 @@
>>   
>>   struct xe_modparam xe_modparam = {
>>   	.probe_display = true,
>> -	.guc_log_level = 5,
>> +	.guc_log_level = 3,
>>   	.force_probe = CONFIG_DRM_XE_FORCE_PROBE,
>>   #ifdef CONFIG_PCI_IOV
>>   	.max_vfs = IS_ENABLED(CONFIG_DRM_XE_DEBUG) ? ~0 : 0,
>> -- 
>> 2.47.0
>>


  reply	other threads:[~2024-11-08 23:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-08 21:27 [PATCH 0/2] drm/xe/guc: Handle crash notifications & drop default log verbosity John.C.Harrison
2024-11-08 21:27 ` [PATCH 1/2] drm/xe/guc: Reduce default GuC " John.C.Harrison
2024-11-08 23:33   ` Matthew Brost
2024-11-08 23:49     ` John Harrison [this message]
2024-11-08 21:27 ` [PATCH 2/2] drm/xe/guc: Support crash dump notification from GuC John.C.Harrison
2024-11-08 23:35   ` Matthew Brost
2024-11-08 23:51     ` John Harrison
2024-11-08 23:56       ` Matthew Brost
2024-11-09  0:39         ` John Harrison
2024-11-09  2:09           ` John Harrison
2024-11-08 21:50 ` [PATCH 0/2] drm/xe/guc: Handle crash notifications & drop default log verbosity Cavitt, Jonathan
2024-11-08 22:28 ` ✓ CI.Patch_applied: success for " Patchwork
2024-11-08 22:28 ` ✓ CI.checkpatch: " Patchwork
2024-11-08 22:29 ` ✓ CI.KUnit: " Patchwork
2024-11-08 22:41 ` ✓ CI.Build: " Patchwork
2024-11-08 22:43 ` ✓ CI.Hooks: " Patchwork
2024-11-08 22:45 ` ✓ CI.checksparse: " Patchwork
2024-11-08 23:02 ` ✓ CI.BAT: " Patchwork
2024-11-10  1:47 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac48a2e3-6ab6-4518-85ad-0f696e09bebc@intel.com \
    --to=john.c.harrison@intel.com \
    --cc=Intel-Xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox