Re: [PATCH 18/23] drm/i915/psr: Program Panel Replay CONFIG3 using AS SDP transmission time

Ville Syrjälä
2026-04-02T10:30:59Z

On Thu, Apr 02, 2026 at 01:34:18PM +0530, Ankit Nautiyal wrote:
> Panel Replay requires the AS SDP transmission time to be written into
> PANEL_REPLAY_CONFIG3. This field was previously not programmed.
>
> Use the AS SDP transmission-time helper to populate CONFIG3.
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 3fe7691c8b77..a9032b7ff814 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -783,6 +783,7 @@ static void _panel_replay_enable_sink(struct intel_dp *intel_dp,
> const struct intel_crtc_state *crtc_state)
> {
> u8 panel_replay_config[2];
> + u8 panel_replay_config_3;
>
> panel_replay_config[0] = DP_PANEL_REPLAY_ENABLE |
> DP_PANEL_REPLAY_VSC_SDP_CRC_EN |
> @@ -790,7 +791,6 @@ static void _panel_replay_enable_sink(struct intel_dp *intel_dp,
> DP_PANEL_REPLAY_RFB_STORAGE_ERROR_EN |
> DP_PANEL_REPLAY_ACTIVE_FRAME_CRC_ERROR_EN;
> panel_replay_config[1] = DP_PANEL_REPLAY_CRC_VERIFICATION;
> -
> if (crtc_state->has_sel_update)
> panel_replay_config[0] |= DP_PANEL_REPLAY_SU_ENABLE;
>
> @@ -803,6 +803,9 @@ static void _panel_replay_enable_sink(struct intel_dp *intel_dp,
>
> drm_dp_dpcd_write(&intel_dp->aux, PANEL_REPLAY_CONFIG,
> panel_replay_config, sizeof(panel_replay_config));
> +
> + panel_replay_config_3 = intel_dp_as_sdp_transmission_time();
> + drm_dp_dpcd_writeb(&intel_dp->aux, PANEL_REPLAY_CONFIG3, panel_replay_config_3);
> }
>
> static void _psr_enable_sink(struct intel_dp *intel_dp,
> --
> 2.45.2

--
Ville Syrjälä
Intel