Re: [PATCH] drm/xe: Suppress reset log for destroyed queues

[Matthew Brost <matthew.brost@intel.com>]

On Thu, Apr 02, 2026 at 02:30:30PM -0700, Daniele Ceraolo Spurio wrote:
> When a queue is destroyed while still active on the HW (for example
> because the app owning it is exiting abruptly), the driver tells the GuC
> to preempt it off the HW immediately and to reset it if it doesn't
> preempt. This can cause a reset log to be printed to dmesg, which can
> be confusing to users as resets are commonly tied to errors, while in
> this case the reset is just done to speed up the cleanup.
> Given that a queue is only destroyed once all refs on it have been
> released (i.e., no one cares about it anymore), the log of it being
> reset is not useful and therefore we can simply suppress it to avoid
> confusion.
> 
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 10556156eaad..e6702bd99309 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -2968,9 +2968,10 @@ int xe_guc_exec_queue_reset_handler(struct xe_guc *guc, u32 *msg, u32 len)
>  	if (unlikely(!q))
>  		return -EPROTO;
>  
> -	xe_gt_info(gt, "Engine reset: engine_class=%s, logical_mask: 0x%x, guc_id=%d, state=0x%0x",
> -		   xe_hw_engine_class_to_str(q->class), q->logical_mask, guc_id,
> -		   atomic_read(&q->guc->state));
> +	if (!exec_queue_destroyed(q))

I think you want killed here—right? Destroyed is tied to the refcount,
whereas killed is tied to either a user closing an exec_queue or the DRM
render FD being closed. There may also be a multi-queue case that needs
slightly different logic. I forget the exact multi-queue teardown flow,
but IIRC it is slightly different. Niranjana would likely know that
offhand; otherwise, I’d have to reverse-engineer those flows again.

Matt

> +		xe_gt_info(gt, "Engine reset: engine_class=%s, logical_mask: 0x%x, guc_id=%d, state=0x%0x",
> +			   xe_hw_engine_class_to_str(q->class), q->logical_mask, guc_id,
> +			   atomic_read(&q->guc->state));
>  
>  	trace_xe_exec_queue_reset(q);
>  
> -- 
> 2.43.0
>