From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B62D106B50B for ; Wed, 25 Mar 2026 12:15:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 343F610E8A2; Wed, 25 Mar 2026 12:15:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HNjiqDOF"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B94510E8A2; Wed, 25 Mar 2026 12:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774440959; x=1805976959; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=H0jh73TeIQCIPSPezg+IReK8Aau451nRcjXwk3du2nA=; b=HNjiqDOFEIrot/C5l2aFEqYQD46hRaL1R6m0YrFFJ2/mhHgX+Obc1D7W 81KfUfSvACkeLKePT4dvV6ODXcXqptKcgni0SLhkft9Q46KhSvd4dIeNx iqLj8aeNdKPGuFmWXK8ErOqHK5eP21QZ8TF1gH0rdV95AlBLq+4tPHVDl ndbFulsddcLphIOEXroMaUVlFCtHdA6s90bzzBFG4uBlc9H18uMsgjJGr AoM0IozeAZtQXH33qpFb+ZsrUyZrB8nEOO144G9Ww8smhj0QXg6aaGc4s ucmEKNnxi+B4wxX1+ygnit3mzdt7kkC7ZKkXqNJVcnjOOg+RR/CWKr9eE w==; X-CSE-ConnectionGUID: gO6BAVOqTA611SchYD1K5Q== X-CSE-MsgGUID: /adgcg5pQX2ijwrbmSXPlQ== X-IronPort-AV: E=McAfee;i="6800,10657,11739"; a="92854737" X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="92854737" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 05:15:58 -0700 X-CSE-ConnectionGUID: m2dTsAFNQxO3PTbo5iymHQ== X-CSE-MsgGUID: fDvp1ZXbQjqcAemxRr0/Bw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="219811628" Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.117]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 05:15:55 -0700 Date: Wed, 25 Mar 2026 14:15:52 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Suraj Kandpal Cc: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, sowmiya.s@intel.com, uma.shankar@intel.com, swati2.sharma@intel.com, chaitanya.kumar.borah@intel.com, arun.r.murthy@intel.com Subject: Re: [PATCH v3 09/26] drm/i915/writeback: Fill encoder->get_config Message-ID: References: <20260325110744.1096786-1-suraj.kandpal@intel.com> <20260325110744.1096786-10-suraj.kandpal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260325110744.1096786-10-suraj.kandpal@intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, Mar 25, 2026 at 04:37:27PM +0530, Suraj Kandpal wrote: > Fill the encoder->get_config hook with relevant data which helps > verify state. > > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/display/intel_writeback.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_writeback.c b/drivers/gpu/drm/i915/display/intel_writeback.c > index 64769609aefe..1df04538d48c 100644 > --- a/drivers/gpu/drm/i915/display/intel_writeback.c > +++ b/drivers/gpu/drm/i915/display/intel_writeback.c > @@ -100,6 +100,14 @@ static const struct drm_connector_helper_funcs conn_helper_funcs = { > .mode_valid = intel_writeback_mode_valid, > }; > > +static void > +intel_writeback_get_config(struct intel_encoder *encoder, > + struct intel_crtc_state *crtc_state) > +{ > + crtc_state->output_types |= BIT(INTEL_OUTPUT_WRITEBACK); > + crtc_state->output_format = INTEL_OUTPUT_FORMAT_RGB; That should already be covered by hsw_get_pipe_config() > +} > + > static bool > intel_writeback_get_hw_state(struct intel_encoder *encoder, > enum pipe *pipe) > @@ -170,6 +178,7 @@ int intel_writeback_init(struct intel_display *display) > encoder->type = INTEL_OUTPUT_WRITEBACK; > encoder->pipe_mask = ~0; > encoder->cloneable = 0; > + encoder->get_config = intel_writeback_get_config; > encoder->get_hw_state = intel_writeback_get_hw_state; > > connector = &writeback_conn->connector; > -- > 2.34.1 -- Ville Syrjälä Intel