Re: [PATCH v3 13/26] drm/i915/writeback: Define function for connector function detect

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Mar 25, 2026 at 04:37:31PM +0530, Suraj Kandpal wrote:
> detect function always returns connector_status_connected if
> writeback connector has been initialized.
> 
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_writeback.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_writeback.c b/drivers/gpu/drm/i915/display/intel_writeback.c
> index b9350d97de09..e677cdfa6207 100644
> --- a/drivers/gpu/drm/i915/display/intel_writeback.c
> +++ b/drivers/gpu/drm/i915/display/intel_writeback.c
> @@ -154,11 +154,19 @@ static void intel_writeback_cleanup_job(struct drm_connector *connector,
>  	job->priv = NULL;
>  }
>  
> +static enum drm_connector_status
> +intel_writeback_detect(struct drm_connector *connector,
> +		       bool force)
> +{
> +	return connector_status_connected;

Pointless. See detect_connector_status() in the probe helper.

> +}
> +
>  static const struct drm_encoder_funcs drm_writeback_encoder_funcs = {
>  	.destroy = drm_encoder_cleanup,
>  };
>  
>  const struct drm_connector_funcs conn_funcs = {
> +	.detect = intel_writeback_detect,
>  	.fill_modes = drm_helper_probe_single_connector_modes,
>  	.atomic_duplicate_state = intel_digital_connector_duplicate_state,
>  	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
> -- 
> 2.34.1

-- 
Ville Syrjälä
Intel