From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A10F3106B519 for ; Wed, 25 Mar 2026 12:22:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 671A210E872; Wed, 25 Mar 2026 12:22:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="euTBXs8q"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50E1C10E8AF; Wed, 25 Mar 2026 12:22:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774441366; x=1805977366; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=JHK5FhqtZVpn0C9k9GKBRQVwybRPss55bwvrZ11BPwU=; b=euTBXs8qTJ8todgafG3loobpJk6AMG6PscZazd2ouDkgv5Y0t2i8M3CK //etUxIL2lEoSkmvElZxjvnXM2jY3rJbIgSKnKq+SPpcDknsX+rhzT1H2 jEeDaaP0tnXjvtmgEIJ1ShMS7YfYwVvVBO7mnlzo/Y/MLD7vIxvL9+9r7 qpJGJl1dpKKwdgvuoKy/xZzdaCYSWgCUHZZbtKcFmN9a2rLbukIr4Ir3+ GYKBMuEeyf6EtFCMp4xbz0l+9DAOpzMzm9xqTFpjVrdKW2IYMTJ/jMxWc 1+9ym2Qo6l+OY/HtWnp2Cxp+a/ppP8dvXkc1IgNkjwK4Jl3DPnhJPIBxs w==; X-CSE-ConnectionGUID: OviQtFLhQ3O7AnIGOs86FQ== X-CSE-MsgGUID: rsaIQ3KLRr++DhilVg7lJA== X-IronPort-AV: E=McAfee;i="6800,10657,11739"; a="92855387" X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="92855387" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 05:22:43 -0700 X-CSE-ConnectionGUID: SDAFtkpLR7qIaj3S5U0o5w== X-CSE-MsgGUID: +Kwa+HiERmaF59nxU1BmhA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,140,1770624000"; d="scan'208";a="229124450" Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.117]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2026 05:22:41 -0700 Date: Wed, 25 Mar 2026 14:22:37 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Suraj Kandpal Cc: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, sowmiya.s@intel.com, uma.shankar@intel.com, swati2.sharma@intel.com, chaitanya.kumar.borah@intel.com, arun.r.murthy@intel.com Subject: Re: [PATCH v3 13/26] drm/i915/writeback: Define function for connector function detect Message-ID: References: <20260325110744.1096786-1-suraj.kandpal@intel.com> <20260325110744.1096786-14-suraj.kandpal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260325110744.1096786-14-suraj.kandpal@intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, Mar 25, 2026 at 04:37:31PM +0530, Suraj Kandpal wrote: > detect function always returns connector_status_connected if > writeback connector has been initialized. > > Signed-off-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/display/intel_writeback.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_writeback.c b/drivers/gpu/drm/i915/display/intel_writeback.c > index b9350d97de09..e677cdfa6207 100644 > --- a/drivers/gpu/drm/i915/display/intel_writeback.c > +++ b/drivers/gpu/drm/i915/display/intel_writeback.c > @@ -154,11 +154,19 @@ static void intel_writeback_cleanup_job(struct drm_connector *connector, > job->priv = NULL; > } > > +static enum drm_connector_status > +intel_writeback_detect(struct drm_connector *connector, > + bool force) > +{ > + return connector_status_connected; Pointless. See detect_connector_status() in the probe helper. > +} > + > static const struct drm_encoder_funcs drm_writeback_encoder_funcs = { > .destroy = drm_encoder_cleanup, > }; > > const struct drm_connector_funcs conn_funcs = { > + .detect = intel_writeback_detect, > .fill_modes = drm_helper_probe_single_connector_modes, > .atomic_duplicate_state = intel_digital_connector_duplicate_state, > .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, > -- > 2.34.1 -- Ville Syrjälä Intel