From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81B6510A62D6 for ; Thu, 26 Mar 2026 14:02:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4497D10E96B; Thu, 26 Mar 2026 14:02:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="fRf2bbX8"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 18E2B10E96B; Thu, 26 Mar 2026 14:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774533770; x=1806069770; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=CDIStDgQz1sj3KJMv16V8d5X9tOYrTtSIxL1JrT5Oow=; b=fRf2bbX8KES4iwaQUpDHUNIEfEW4DId+WEqlMDwU9owTXckaG0/wDw1q YCAcqA8HWzAW1cFcG70om//5UInhcqs93Fcr5C6KEs+jVcLhupgtSKUZK lMsaWc6lUI8ZNqpFLoiEUbO15uCAAdsoqZHpcBNZmf5ey1yIWBil/rJzV vOWBQ2hARFFLmsy/cGcLxWQHZBWX07jVZ8krv5PIgQS4V/htGta1+NWR6 UavTwuxt+s4veYTf8oSlJDqgJe7PUyaAcpinMSGdLrdkiO4JvBrTs3Dvq ov28MmGsEcU50iQZpHJjgtsK1pp4dao9NCwiqxr/NiyYchEHLP7e4wDwh Q==; X-CSE-ConnectionGUID: 8goCGFElTuKDTUATK6zvVw== X-CSE-MsgGUID: Eb8gYR48SACFhETBRYGRPA== X-IronPort-AV: E=McAfee;i="6800,10657,11741"; a="75480767" X-IronPort-AV: E=Sophos;i="6.23,142,1770624000"; d="scan'208";a="75480767" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 07:02:42 -0700 X-CSE-ConnectionGUID: 4f4rCzkbR16Y9MxHGJkCsA== X-CSE-MsgGUID: 6dji/yuqT5m5wecKNC05sQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,142,1770624000"; d="scan'208";a="248058378" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.14]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Mar 2026 07:02:41 -0700 Date: Thu, 26 Mar 2026 16:02:38 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [PATCH 3/5] drm/i915/dsi: Make 'clock_stop' boolean Message-ID: References: <20260326111814.9800-1-ville.syrjala@linux.intel.com> <20260326111814.9800-4-ville.syrjala@linux.intel.com> <1558669af43583b072c8c58eff1e01960c2d9f8c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1558669af43583b072c8c58eff1e01960c2d9f8c@intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, Mar 26, 2026 at 03:40:56PM +0200, Jani Nikula wrote: > On Thu, 26 Mar 2026, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > The DSI 'clock_stop' parameter is a boolean, so use a real > > 'bool' for it. And pimp the debug print while at it. > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/i915/display/intel_dsi.h | 2 +- > > drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dsi.h b/drivers/gpu/drm/i915/display/intel_dsi.h > > index 8e39d2b52c54..0023ac341aa0 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dsi.h > > +++ b/drivers/gpu/drm/i915/display/intel_dsi.h > > @@ -81,7 +81,7 @@ struct intel_dsi { > > int video_mode; > > > > bool eot_pkt; > > - u8 clock_stop; > > + bool clock_stop; > > > > u8 escape_clk_div; > > u8 dual_link; > > diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > > index 51f6a5b82cb2..23da7f5f9578 100644 > > --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > > +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c > > @@ -719,7 +719,7 @@ void intel_dsi_log_params(struct intel_dsi *intel_dsi) > > drm_printf(&p, "Burst mode ratio %d\n", intel_dsi->burst_mode_ratio); > > drm_printf(&p, "Reset timer %d\n", intel_dsi->rst_timer_val); > > drm_printf(&p, "EoT packet %s\n", str_enabled_disabled(intel_dsi->eot_pkt)); > > - drm_printf(&p, "Clockstop %s\n", str_enabled_disabled(!intel_dsi->clock_stop)); > > + drm_printf(&p, "Clock stop during BLLP %s\n", str_enabled_disabled(intel_dsi->clock_stop)); > > What's with the reversed !intel_dsi->clock_stop in the existing log and > the change here? I've had these sitting around for a while so completely forgot I changed it. Looks that it's been wrong since the initial commit. Apparently v2 of the patch https://lore.kernel.org/intel-gfx/1397454507-10273-5-git-send-email-shobhit.kumar@intel.com/ had it the correct way around, but then it got messed in in v3 while the capital letters were being made lowercase. I can split that out into its own patch with that explanation. > > > drm_printf(&p, "Mode %s\n", intel_dsi->operation_mode ? "command" : "video"); > > if (intel_dsi->dual_link == DSI_DUAL_LINK_FRONT_BACK) > > drm_printf(&p, "Dual link: DSI_DUAL_LINK_FRONT_BACK\n"); > > @@ -771,7 +771,7 @@ bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id) > > drm_dbg_kms(display->drm, "\n"); > > > > intel_dsi->eot_pkt = !mipi_config->eot_pkt_disabled; > > - intel_dsi->clock_stop = mipi_config->enable_clk_stop ? 1 : 0; > > + intel_dsi->clock_stop = mipi_config->enable_clk_stop; > > intel_dsi->lane_count = mipi_config->lane_cnt + 1; > > intel_dsi->pixel_format = > > vbt_to_dsi_pixel_format(mipi_config->videomode_color_format); > > -- > Jani Nikula, Intel -- Ville Syrjälä Intel