[PATCH] drm/xe/xe_vm: Convert comma to semicolon

[PATCH] drm/xe/xe_vm: Convert comma to semicolon

[Chen Ni]

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/gpu/drm/xe/xe_vm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index d96e0a0c5605..21844217dccd 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -626,9 +626,9 @@ void xe_vm_add_fault_entry_pf(struct xe_vm *vm, struct xe_pagefault *pf)
 	e->address_precision = SZ_4K;
 	e->access_type = pf->consumer.access_type;
 	e->fault_type = FIELD_GET(XE_PAGEFAULT_TYPE_MASK,
-				  pf->consumer.fault_type_level),
+				  pf->consumer.fault_type_level);
 	e->fault_level = FIELD_GET(XE_PAGEFAULT_LEVEL_MASK,
-				   pf->consumer.fault_type_level),
+				   pf->consumer.fault_type_level);
 
 	list_add_tail(&e->list, &vm->faults.list);
 	vm->faults.len++;
-- 
2.25.1

Re: [PATCH] drm/xe/xe_vm: Convert comma to semicolon

[Rodrigo Vivi]

On Fri, Mar 27, 2026 at 11:29:23AM +0800, Chen Ni wrote:
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/gpu/drm/xe/xe_vm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index d96e0a0c5605..21844217dccd 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -626,9 +626,9 @@ void xe_vm_add_fault_entry_pf(struct xe_vm *vm, struct xe_pagefault *pf)
>  	e->address_precision = SZ_4K;
>  	e->access_type = pf->consumer.access_type;
>  	e->fault_type = FIELD_GET(XE_PAGEFAULT_TYPE_MASK,
> -				  pf->consumer.fault_type_level),
> +				  pf->consumer.fault_type_level);
>  	e->fault_level = FIELD_GET(XE_PAGEFAULT_LEVEL_MASK,
> -				   pf->consumer.fault_type_level),
> +				   pf->consumer.fault_type_level);

This code is not present in our tree.

In the xe_pagefault.c where this FIELD_GET commands are actually implemented,
the comma is the right way.


>  
>  	list_add_tail(&e->list, &vm->faults.list);
>  	vm->faults.len++;
> -- 
> 2.25.1
> 

✗ LGCI.VerificationFailed: failure for drm/xe/xe_vm: Convert comma to semicolon

[Patchwork]

== Series Details ==

Series: drm/xe/xe_vm: Convert comma to semicolon
URL   : https://patchwork.freedesktop.org/series/164081/
State : failure

== Summary ==

Address 'nichen@iscas.ac.cn' is not on the allowlist, which prevents CI from being triggered for this patch.
If you want Intel GFX CI to accept this address, please contact the script maintainers at i915-ci-infra@lists.freedesktop.org.
Exception occurred during validation, bailing out!

RE: [PATCH] drm/xe/xe_vm: Convert comma to semicolon

[Lin, Shuicheng]

On Thu, Mar 26, 2026 8:29 PM Chen Ni wrote:
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

LGTM.
Reviewed-by: Shuicheng Lin <shuicheng.lin@intel.com>

BTW, it is blocked by the CI due to the mail address restriction. Let me re-send it for CI validation.
Thanks. 

> ---
>  drivers/gpu/drm/xe/xe_vm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c index
> d96e0a0c5605..21844217dccd 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -626,9 +626,9 @@ void xe_vm_add_fault_entry_pf(struct xe_vm *vm,
> struct xe_pagefault *pf)
>  	e->address_precision = SZ_4K;
>  	e->access_type = pf->consumer.access_type;
>  	e->fault_type = FIELD_GET(XE_PAGEFAULT_TYPE_MASK,
> -				  pf->consumer.fault_type_level),
> +				  pf->consumer.fault_type_level);
>  	e->fault_level = FIELD_GET(XE_PAGEFAULT_LEVEL_MASK,
> -				   pf->consumer.fault_type_level),
> +				   pf->consumer.fault_type_level);
> 
>  	list_add_tail(&e->list, &vm->faults.list);
>  	vm->faults.len++;
> --
> 2.25.1