Re: [PATCH] drm/xe/uc: Track uc firmware state changes

Matthew Brost
2026-03-27T20:27:26Z

On Fri, Mar 27, 2026 at 09:24:06PM +0100, Michal Wajdeczko wrote:
> Under CONFIG_DRM_XE_DEBUG_GUC print debug messages with each uc
> firmware state transition to better visualize the changes.
>
> [drm:xe_uc_fw_change_status [xe]] Tile0: GT0: GuC UNINITIALIZED->SELECTED
> [drm:xe_uc_fw_change_status [xe]] Tile0: GT0: GuC SELECTED->AVAILABLE
> [drm:xe_uc_fw_change_status [xe]] Tile0: GT0: GuC AVAILABLE->LOADABLE
> [drm:xe_uc_fw_change_status [xe]] Tile0: GT0: GuC LOADABLE->TRANSFERRED
> [drm:xe_uc_fw_change_status [xe]] Tile0: GT0: GuC TRANSFERRED->RUNNING
>

Seeems useful.

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> drivers/gpu/drm/xe/xe_uc_fw.c | 11 +++++++++++
> drivers/gpu/drm/xe/xe_uc_fw.h | 4 ++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c
> index 42d290e8585a..b5a49ef9dafe 100644
> --- a/drivers/gpu/drm/xe/xe_uc_fw.c
> +++ b/drivers/gpu/drm/xe/xe_uc_fw.c
> @@ -218,6 +218,17 @@ static struct xe_device *uc_fw_to_xe(struct xe_uc_fw *uc_fw)
> return gt_to_xe(uc_fw_to_gt(uc_fw));
> }
>
> +#if IS_ENABLED(CONFIG_DRM_XE_DEBUG_GUC)
> +void xe_uc_fw_change_status(struct xe_uc_fw *uc_fw, enum xe_uc_fw_status status)
> +{
> + xe_gt_dbg(uc_fw_to_gt(uc_fw), "%s %s->%s\n",
> + xe_uc_fw_type_repr(uc_fw->type),
> + xe_uc_fw_status_repr(uc_fw->status),
> + xe_uc_fw_status_repr(status));
> + uc_fw->__status = status;
> +}
> +#endif
> +
> static void
> uc_fw_auto_select(struct xe_device *xe, struct xe_uc_fw *uc_fw)
> {
> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.h b/drivers/gpu/drm/xe/xe_uc_fw.h
> index 6195e353f269..bb281b72a677 100644
> --- a/drivers/gpu/drm/xe/xe_uc_fw.h
> +++ b/drivers/gpu/drm/xe/xe_uc_fw.h
> @@ -25,11 +25,15 @@ static inline u32 xe_uc_fw_rsa_offset(struct xe_uc_fw *uc_fw)
> return sizeof(struct uc_css_header) + uc_fw->ucode_size + uc_fw->css_offset;
> }
>
> +#if IS_ENABLED(CONFIG_DRM_XE_DEBUG_GUC)
> +void xe_uc_fw_change_status(struct xe_uc_fw *uc_fw, enum xe_uc_fw_status status);
> +#else
> static inline void xe_uc_fw_change_status(struct xe_uc_fw *uc_fw,
> enum xe_uc_fw_status status)
> {
> uc_fw->__status = status;
> }
> +#endif
>
> static inline
> const char *xe_uc_fw_status_repr(enum xe_uc_fw_status status)
> --
> 2.47.1
>