Re: [PATCH] drm/xe/xe3: Recognize 3DSTATE_COARSE_PIXEL to LRC dumps

["Pottumuttu, Sai Teja" <sai.teja.pottumuttu@intel.com>]

On 08-03-2025 00:37, Matt Roper wrote:
> Xe3 adds a new 3DSTATE_COARSE_PIXEL state instruction as part of the
> render engine LRC.  Ensure we can recognize and report this properly in
> the LRC dumps.
> 
> Bspec: 65182, 73415
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

Just a nit, it should be 'in LRC dumps' in the subject probably, other 
than that

LGTM,

Reviewed-by: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>


> ---
>   drivers/gpu/drm/xe/instructions/xe_gfxpipe_commands.h | 1 +
>   drivers/gpu/drm/xe/xe_lrc.c                           | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/instructions/xe_gfxpipe_commands.h b/drivers/gpu/drm/xe/instructions/xe_gfxpipe_commands.h
> index 31d28a67ef6a..457881af8af9 100644
> --- a/drivers/gpu/drm/xe/instructions/xe_gfxpipe_commands.h
> +++ b/drivers/gpu/drm/xe/instructions/xe_gfxpipe_commands.h
> @@ -137,6 +137,7 @@
>   #define CMD_3DSTATE_CLIP_MESH			GFXPIPE_3D_CMD(0x0, 0x81)
>   #define CMD_3DSTATE_SBE_MESH			GFXPIPE_3D_CMD(0x0, 0x82)
>   #define CMD_3DSTATE_CPSIZE_CONTROL_BUFFER	GFXPIPE_3D_CMD(0x0, 0x83)
> +#define CMD_3DSTATE_COARSE_PIXEL		GFXPIPE_3D_CMD(0x0, 0x89)
>   
>   #define CMD_3DSTATE_DRAWING_RECTANGLE		GFXPIPE_3D_CMD(0x1, 0x0)
>   #define CMD_3DSTATE_CHROMA_KEY			GFXPIPE_3D_CMD(0x1, 0x4)
> diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
> index df3ceddede07..81def1792664 100644
> --- a/drivers/gpu/drm/xe/xe_lrc.c
> +++ b/drivers/gpu/drm/xe/xe_lrc.c
> @@ -1445,6 +1445,7 @@ static int dump_gfxpipe_command(struct drm_printer *p,
>   	MATCH3D(3DSTATE_CLIP_MESH);
>   	MATCH3D(3DSTATE_SBE_MESH);
>   	MATCH3D(3DSTATE_CPSIZE_CONTROL_BUFFER);
> +	MATCH3D(3DSTATE_COARSE_PIXEL);
>   
>   	MATCH3D(3DSTATE_DRAWING_RECTANGLE);
>   	MATCH3D(3DSTATE_CHROMA_KEY);