From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E0831061B15 for ; Mon, 30 Mar 2026 18:22:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 28CE110E6D9; Mon, 30 Mar 2026 18:22:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="MD9Qta+R"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E84410E359; Mon, 30 Mar 2026 18:22:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774894934; x=1806430934; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=nVqFXQrpV+MuPq6e09M1FK312UXZn40cqsCDN+6Uka0=; b=MD9Qta+RsIzzWg359Vbq0jCgcj1DztAq0s7gc21Abti+vWphJlX7yy4J L1lmyhr2grlCzV4PopuvWLLKuGYQg78TOcVeVJgyEnIQaED6iwjIZuNDZ 9AaMapqBFetfA7BESgkTJ1LjBMeOmg/OwWT7mB3XsYkAbzelRQeWH1uNb AsF/ug9SJctqemuf8kxNlh1K7pCI2EMboWJ6jdnOAY+CPFJ7+lEnUZGHu MVCReAZBqDXi/PQWctjqNMvTRpDNqqpIbReE0fL8sOYFV2zsoqKEnYHCU fvIAnsSiZ4ovlpKmPtM2GyPty36zHR+LxCbK9rQq6ICA7iIC3pZORASX4 Q==; X-CSE-ConnectionGUID: v6nXoUYzTRGU7l2bDw9tQg== X-CSE-MsgGUID: 4h4uXLcSSOuNotlvnJ3gxw== X-IronPort-AV: E=McAfee;i="6800,10657,11743"; a="79498936" X-IronPort-AV: E=Sophos;i="6.23,150,1770624000"; d="scan'208";a="79498936" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2026 11:22:13 -0700 X-CSE-ConnectionGUID: VpsmRRODTDu9xBuJCZivrg== X-CSE-MsgGUID: MpoiMbouQByzbYeCldBoBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,150,1770624000"; d="scan'208";a="219481705" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.155]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2026 11:22:11 -0700 Date: Mon, 30 Mar 2026 21:22:09 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Ankit Nautiyal Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, jouni.hogander@intel.com, animesh.manna@intel.com Subject: Re: [PATCH 09/19] drm/i915/dp: Skip AS SDP for DP branch devices Message-ID: References: <20260330040656.4116502-1-ankit.k.nautiyal@intel.com> <20260330040656.4116502-10-ankit.k.nautiyal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260330040656.4116502-10-ankit.k.nautiyal@intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, Mar 30, 2026 at 09:36:46AM +0530, Ankit Nautiyal wrote: > Currently, VRR is not implmented for DP branch devices. > So skip sending AS SDP for them. Sure why not. Reviewed-by: Ville Syrjälä > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_dp.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c > index 7ca3f9d583db..1a35478411d7 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -3130,6 +3130,12 @@ static bool intel_dp_can_use_as_sdp(struct intel_dp *intel_dp, > if (!intel_dp->as_sdp_supported) > return false; > > + /* > + * #TODO Implement AS SDP for DP branch device. > + */ > + if (drm_dp_is_branch(intel_dp->dpcd)) > + return false; > + > return crtc_state->vrr.enable; > } > > -- > 2.45.2 -- Ville Syrjälä Intel