From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AAD11061B15 for ; Mon, 30 Mar 2026 18:26:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 70EEA10E4B3; Mon, 30 Mar 2026 18:26:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="WHFUFl6p"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id A3A8510E1E7; Mon, 30 Mar 2026 18:26:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774895207; x=1806431207; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=HvZ/3BeNvE0Xz59u4abtmO2yGkWQ7JC65eBVTPjZc68=; b=WHFUFl6p/Hspi8llsE5VrWA6Rog1E73AhVqLGVeelQu5uvDrCHfRnePg LbSPeqGsBnPjnVdJ3XXItKkq/mjtzuNvDzK37DPxMgdj2oi16/5FwYRUD yRN/bVBtGGke3szai8WR8frS9AYNdi17yf2NPG9LVTwegtcWCZSLQ4D7W 6Yok3cZ/KLAwv0A7IjOrB89OA9+0QQzVazimsxr3JKLkaeEdk0H2z95gE GDPTGx9s7LRh6boTR5L9weoXqzGj8xCvNUeD+m4ZymViiEsS/PQt1XfEu s6yiCKb/it4C7+i2nF9X4QNuF8pkXEsMMF8wxGGwCtUHsjAmvmDqOzpxk Q==; X-CSE-ConnectionGUID: y4M2/ciOSiGPc8VBwSYA4w== X-CSE-MsgGUID: 53rsQY2ARw2YFw/BiRtxuQ== X-IronPort-AV: E=McAfee;i="6800,10657,11743"; a="74928240" X-IronPort-AV: E=Sophos;i="6.23,150,1770624000"; d="scan'208";a="74928240" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2026 11:26:47 -0700 X-CSE-ConnectionGUID: RynDOM0FTNqd5qTa+4pCVQ== X-CSE-MsgGUID: txLIgMbMRzW2cSW1Hh8Pxw== X-ExtLoop1: 1 Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.155]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2026 11:26:45 -0700 Date: Mon, 30 Mar 2026 21:26:43 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Ankit Nautiyal Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, jouni.hogander@intel.com, animesh.manna@intel.com Subject: Re: [PATCH 11/19] drm/i915/dp: Include all relevant AS SDP fields in comparison Message-ID: References: <20260330040656.4116502-1-ankit.k.nautiyal@intel.com> <20260330040656.4116502-12-ankit.k.nautiyal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260330040656.4116502-12-ankit.k.nautiyal@intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, Mar 30, 2026 at 09:36:48AM +0530, Ankit Nautiyal wrote: > Add missing drm_dp_as_sdp header fields to intel_compare_dp_as_sdp() > comparison. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_display.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index 57870baebfa5..a0e7ef2574b2 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -4906,11 +4906,14 @@ static bool > intel_compare_dp_as_sdp(const struct drm_dp_as_sdp *a, > const struct drm_dp_as_sdp *b) > { > - return a->revision == b->revision && > + return a->sdp_type == b->sdp_type && > + a->revision == b->revision && > + a->length == b->length && > a->vtotal == b->vtotal && > a->target_rr == b->target_rr && > a->duration_incr_ms == b->duration_incr_ms && > a->duration_decr_ms == b->duration_decr_ms && > + a->target_rr_divider == b->target_rr_divider && > a->mode == b->mode; BTW do we know if the hardware actually modifies the AS SDP DIP buffer, or does it just override some of the values as the SDP is being transmitted? If the former then I guess we have to keep in mind that the readout may have to do some sanitizing to avoid mismatches, if we do anything that require the hardware to dynamically adjust the AS SDP. Reviewed-by: Ville Syrjälä > } > > -- > 2.45.2 -- Ville Syrjälä Intel