From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E8291061B18 for ; Mon, 30 Mar 2026 18:54:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 97ADC10E6C6; Mon, 30 Mar 2026 18:54:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="DXaQOpxi"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03C1D10E772; Mon, 30 Mar 2026 18:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774896864; x=1806432864; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=xPea/rqNVS9a/xCgCwcOjBGU0n2Q1ZbkcnvwKfw7+QI=; b=DXaQOpxiLN9Rl4+1Be5cXb/czuFUJvukHUdP9AajAIAFGi9m/tTUyVAN f1DlOeLlxqTkxEtxYzdjaOYxX9l9KQXiudFpB0gQLMPHdQEDSlzBlCvWc A3MxvXFJd1tpwfbwPnX9IuzdXZdAD/D64xY0mXQGKP5+XwO4Gf64QTp2X opiOgh1lo3mfOf1Rxhtxlr+cY2ThG/ko5Fj7g/6LmIUvFLE7nrO+EhmIU IL1ypESEzxsSMNx2jASflRrwgspuKOdNtI4gLjooiIGQKuTbnk9ObkXY3 SVAgVuC1o/65DBxrF3CytP9aC7nbO4gOdO4wWPEwn2jxxksniFcWQ20Zn A==; X-CSE-ConnectionGUID: PxMXp1V1SnuqYo8xOjyONw== X-CSE-MsgGUID: sIVKCRrMTYedQPjxCb+dJQ== X-IronPort-AV: E=McAfee;i="6800,10657,11744"; a="75615239" X-IronPort-AV: E=Sophos;i="6.23,150,1770624000"; d="scan'208";a="75615239" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2026 11:54:23 -0700 X-CSE-ConnectionGUID: 39/0aDhbQIWFNSaQEKbhlw== X-CSE-MsgGUID: M6NHJHnIS3GDea6XgTaXvQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,150,1770624000"; d="scan'208";a="230201286" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.155]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2026 11:54:20 -0700 Date: Mon, 30 Mar 2026 21:54:16 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Ankit Nautiyal Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, jouni.hogander@intel.com, animesh.manna@intel.com Subject: Re: [PATCH 15/19] drm/i915/psr: Program Panel Replay CONFIG3 using AS SDP transmission time Message-ID: References: <20260330040656.4116502-1-ankit.k.nautiyal@intel.com> <20260330040656.4116502-16-ankit.k.nautiyal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260330040656.4116502-16-ankit.k.nautiyal@intel.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, Mar 30, 2026 at 09:36:52AM +0530, Ankit Nautiyal wrote: > Panel Replay requires the AS SDP transmission time to be written into > PANEL_REPLAY_CONFIG3. This field was previously not programmed. > > Use the AS SDP transmission-time helper to populate CONFIG3. > > Signed-off-by: Ankit Nautiyal > --- > drivers/gpu/drm/i915/display/intel_psr.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c > index ca054135ca30..34b0993d9b1d 100644 > --- a/drivers/gpu/drm/i915/display/intel_psr.c > +++ b/drivers/gpu/drm/i915/display/intel_psr.c > @@ -783,7 +783,7 @@ static void _panel_replay_enable_sink(struct intel_dp *intel_dp, > const struct intel_crtc_state *crtc_state) > { > struct intel_display *display = to_intel_display(intel_dp); > - u8 panel_replay_config[2]; > + u8 panel_replay_config[3]; > int ret; > > panel_replay_config[0] = DP_PANEL_REPLAY_ENABLE | > @@ -792,6 +792,7 @@ static void _panel_replay_enable_sink(struct intel_dp *intel_dp, > DP_PANEL_REPLAY_RFB_STORAGE_ERROR_EN | > DP_PANEL_REPLAY_ACTIVE_FRAME_CRC_ERROR_EN; > panel_replay_config[1] = DP_PANEL_REPLAY_CRC_VERIFICATION; > + panel_replay_config[2] = intel_dp_as_sdp_transmission_time(); PANEL_REPLAY_CONFIG3 0x11a ... PANEL_REPLAY_CONFIG1 0x1b0 PANEL_REPLAY_CONFIG2 0x1b1 So apparently we can't do the burst write for all three :/ Looks like 0x1b2 is not used for anything so don't really understand why it wasn't added there. Oh well. > > if (crtc_state->has_sel_update) > panel_replay_config[0] |= DP_PANEL_REPLAY_SU_ENABLE; > -- > 2.45.2 -- Ville Syrjälä Intel