Re: [PATCH 09/19] drm/i915/dp: Skip AS SDP for DP branch devices

Ville Syrjälä
2026-03-30T18:22:16Z

On Mon, Mar 30, 2026 at 09:36:46AM +0530, Ankit Nautiyal wrote:
> Currently, VRR is not implmented for DP branch devices.
> So skip sending AS SDP for them.

Sure why not.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 7ca3f9d583db..1a35478411d7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -3130,6 +3130,12 @@ static bool intel_dp_can_use_as_sdp(struct intel_dp *intel_dp,
> if (!intel_dp->as_sdp_supported)
> return false;
>
> + /*
> + * #TODO Implement AS SDP for DP branch device.
> + */
> + if (drm_dp_is_branch(intel_dp->dpcd))
> + return false;
> +
> return crtc_state->vrr.enable;
> }
>
> --
> 2.45.2

--
Ville Syrjälä
Intel