Re: [PATCH 07/19] drm/i915/dp: Account for AS_SDP guardband only when enabled

Ville Syrjälä
2026-03-30T18:20:08Z

On Mon, Mar 30, 2026 at 09:36:44AM +0530, Ankit Nautiyal wrote:
> Currently the intel_dp_sdp_min_guardband() accounts for AS_SDP for all
> platforms that support adaptive sync SDP even for configurations where
> it cannot be enabled. Instead account for adaptive sync SDP guardband
> only when it is enabled.
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 49eeb35973a1..499850c2abcf 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -7374,7 +7374,6 @@ int intel_dp_get_lines_for_sdp(const struct intel_crtc_state *crtc_state, u32 ty
> int intel_dp_sdp_min_guardband(const struct intel_crtc_state *crtc_state,
> bool assume_all_enabled)
> {
> - struct intel_display *display = to_intel_display(crtc_state);
> int sdp_guardband = 0;
>
> if (assume_all_enabled ||
> @@ -7389,8 +7388,8 @@ int intel_dp_sdp_min_guardband(const struct intel_crtc_state *crtc_state,
> sdp_guardband = max(sdp_guardband,
> intel_dp_get_lines_for_sdp(crtc_state, DP_SDP_PPS));
>
> - if ((assume_all_enabled && HAS_AS_SDP(display)) ||
> - crtc_state->infoframes.enable & intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC))
> + if (crtc_state->infoframes.enable &
> + intel_hdmi_infoframe_enable(DP_SDP_ADAPTIVE_SYNC))
> sdp_guardband = max(sdp_guardband,
> intel_dp_get_lines_for_sdp(crtc_state, DP_SDP_ADAPTIVE_SYNC));
>
> --
> 2.45.2

--
Ville Syrjälä
Intel