Re: [PATCH v2] drm/xe/vm: Add missing pad and extensions check

[Matthew Brost <matthew.brost@intel.com>]

On Tue, Mar 31, 2026 at 06:12:17PM +0000, Jonathan Cavitt wrote:
> Add missing pad and extensions check to xe_vm_get_property_ioctl
> 
> v2:
> - Combine with other check (Auld)
> 
> Fixes: 50c577eab051 ("drm/xe/xe_vm: Implement xe_vm_get_property_ioctl")
> Suggested-by: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_vm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index 56e2db50bb36..1720205c09ca 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -4156,7 +4156,8 @@ int xe_vm_get_property_ioctl(struct drm_device *drm, void *data,
>  	int ret = 0;
>  
>  	if (XE_IOCTL_DBG(xe, (args->reserved[0] || args->reserved[1] ||
> -			      args->reserved[2])))
> +			      args->reserved[2] || args->extensions ||
> +			      args->pad)))
>  		return -EINVAL;
>  
>  	vm = xe_vm_lookup(xef, args->vm_id);
> -- 
> 2.43.0
>