From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1178AF531C1 for ; Mon, 13 Apr 2026 18:38:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C4A6310E506; Mon, 13 Apr 2026 18:38:09 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="nm5XZcu2"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 65DCC10E506; Mon, 13 Apr 2026 18:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776105490; x=1807641490; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=uT/o82FacL8DdO+kdx48Xrar/5NMJIrTKmKjUpVtBIw=; b=nm5XZcu2t1IApAX9oZlzv0IKpV1aASLo+K3CKbQ+6tML2/J3zLkspfGj JLuHTugmNLUpkpPTk6Oa6ZSov2CpBV/7jKvnwpgZCwd5oyBsc41wbLe6n uu6LhU1WFWw9+wql681iqDsXru0OuLqurHwA3bYW0B2MdQyiQyC57aO7x 6cQuzZZ8YbLNIs8ADzpXr34F6zOqq28xJaUcfpZIEYuecA1uw44+GH7VJ o0MhSsjmIL0wKlMA7rQ6vzFD8iGFzZzwB3CsdPIFik6pV+jH5F9dbCg+m Q7V6yHcGtmagpLyufCq6HMSmR2BgvPvK7LwrlCV5OpjXwxORzXifDoGa0 w==; X-CSE-ConnectionGUID: SWMAMyewRuyoAaEWDsVyCA== X-CSE-MsgGUID: UUrkEqsdQTuXY6SZmistRg== X-IronPort-AV: E=McAfee;i="6800,10657,11758"; a="99694805" X-IronPort-AV: E=Sophos;i="6.23,177,1770624000"; d="scan'208";a="99694805" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2026 11:38:09 -0700 X-CSE-ConnectionGUID: O8WUmnUTTAKgW58ipDXiGA== X-CSE-MsgGUID: fKmtr0MpRkSurbbJ+X/j5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,177,1770624000"; d="scan'208";a="234267500" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.97]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2026 11:38:07 -0700 Date: Mon, 13 Apr 2026 21:38:03 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Nicolas Frattaroli Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Ankit Nautiyal Subject: Re: [PATCH v2 0/9] drm/i915/{dp,hdmi}: Restructure DP/HDMI sink format handling Message-ID: References: <20260409101539.22032-1-ville.syrjala@linux.intel.com> <8031984.DvuYhMxLoT@workhorse> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8031984.DvuYhMxLoT@workhorse> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu, Apr 09, 2026 at 05:40:50PM +0200, Nicolas Frattaroli wrote: > On Thursday, 9 April 2026 12:15:30 Central European Summer Time Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Restructure the DP/HDMI sink format handling. I got inspired to do this > > by https://lore.kernel.org/dri-devel/20260324-color-format-v11-8-605559af4fb4@collabora.com/ > > > > I envision that after this the aforementioned patch could just > > become something like this: > > > > 1. s/intel_foo_compute_formats/intel_foo_compute_formats_auto/ > > 2. Add a new intel_foo_compute_formats() > > > > intel_foo_compute_formats() > > { > > switch (color_format) { > > case YCBCR420: > > return intel_foo_compute_output_format(YCBCR420); > > case RGB: > > return intel_foo_compute_output_format(RGB); > > case AUTO: > > return intel_foo_compute_formats_auto(); > > } > > } > > > > v2: A few more updates to the DP mode validation > > > > Cc: Ankit Nautiyal > > Cc: Nicolas Frattaroli > > > > Ville Syrjälä (9): > > drm/i915/hdmi: Add missing intel_pfit_mode_valid() for 4:2:0 also > > modes > > drm/i915/hdmi: Restructure the sink/output format selection > > drm/i915/hdmi: Restructure 4:2:0 vs. 4:4:4 mode validation > > drm/i915/dp: Restructure the sink/output format selection > > drm/i915/dp: Validate "4:2:0 also" modes twice > > drm/i915/dp: Require a HDMI sink for YCbCr output via PCON > > drm/i915/dp: Validate sink format in .mode_valid() > > drm/i915/hdmi: Make the RGB fallback for "4:2:0 only" modes the last > > resort > > drm/i915/dp: Make the RGB fallback for "4:2:0 only" modes the last > > resort > > > > drivers/gpu/drm/i915/display/intel_dp.c | 250 +++++++++++++--------- > > drivers/gpu/drm/i915/display/intel_hdmi.c | 167 +++++++++------ > > 2 files changed, 254 insertions(+), 163 deletions(-) > > > > > > For the whole series: > > Tested-by: Nicolas Frattaroli > > Tested both DisplayPort and HDMI on an N97 board, exercising various > output formats. Thanks for testing and reviews. Pushed to drm-intel-next. -- Ville Syrjälä Intel