Re: [PATCH] drm/xe: Validate preferred system memory placement in xe_svm_range_validate

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 07-01-2026 03:04, Matthew Brost wrote:
> Ensure preferred system memory placement is checked in
> xe_svm_range_validate when dpagemap is NULL. Without this check, a
> prefetch to system memory may become a no-op because device memory is
> considered a valid placement.
> 
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Fixes: 238dbc9d9f4a ("drm/xe: Use the vma attibute drm_pagemap to select where to migrate")
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_svm.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_svm.c b/drivers/gpu/drm/xe/xe_svm.c
> index 05dba6abbcc8..be55b53ace8c 100644
> --- a/drivers/gpu/drm/xe/xe_svm.c
> +++ b/drivers/gpu/drm/xe/xe_svm.c
> @@ -988,6 +988,8 @@ bool xe_svm_range_validate(struct xe_vm *vm,
>   	ret = (range->tile_present & ~range->tile_invalidated & tile_mask) == tile_mask;
>   	if (dpagemap)
>   		ret = ret && xe_svm_range_has_pagemap_locked(range, dpagemap);
> +	else
> +		ret = ret && !range->base.pages.dpagemap;

LGTM.
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

>   
>   	xe_svm_notifier_unlock(vm);
>