Re: [PATCH 06/10] drm/i915: Use a 1 second timeout for the polling vblank wait

Jani Nikula
2026-04-10T15:54:44Z

On Fri, 10 Apr 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> 40 msec seems like a very random number for a vblank wait timeout.
> Considering ~24Hz display modes are definitely a thing this seems
> way too low. Just bump it to a full second to match what we've been
> using for normal vblank waits.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/i915/display/intel_initial_plane.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_initial_plane.c b/drivers/gpu/drm/i915/display/intel_initial_plane.c
> index 74e10d34c63c..4f1591b55752 100644
> --- a/drivers/gpu/drm/i915/display/intel_initial_plane.c
> +++ b/drivers/gpu/drm/i915/display/intel_initial_plane.c
> @@ -36,7 +36,7 @@ void intel_initial_plane_vblank_wait(struct intel_crtc *crtc)
> start_ts = intel_de_read(display, PIPE_FRMTMSTMP(crtc->pipe));
>
> ret = poll_timeout_us(end_ts = intel_de_read(display, PIPE_FRMTMSTMP(crtc->pipe)),
> - end_ts != start_ts, 1000, 40 * 1000, false);
> + end_ts != start_ts, 1000, 1000 * 1000, false);
> if (ret)
> drm_warn(display->drm, "[CRTC:%d:%s] early vblank wait timed out\n",
> crtc->base.base.id, crtc->base.name);

--
Jani Nikula, Intel