Re: [PATCH 04/10] drm/i915: Make plane_config->fb a struct drm_framebuffer*

Jani Nikula
2026-04-14T15:53:40Z

On Tue, 14 Apr 2026, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Apr 10, 2026 at 06:48:02PM +0300, Jani Nikula wrote:
>> On Fri, 10 Apr 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
>> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> >
>> > There's no need to use the intel specific struct intel_framebuffer*
>> > type in the initial plane_config structure. Just make it a
>> > struct drm_framebuffer*.
>>
>> I guess a few words on the "why?" would be nice. I mean they're still
>> pointers to struct intel_framebuffer objects, and could be
>> container_of'd back.
>
> Yeah, meant to put something more sensible here. Basically I think the
> less special types we expose in the interface (even if just pointers)
> the better. At least then there is no need to change the interface
> definition if we ever change the internal types. And I hope that the
> existing examples will generally encourage people to not expose more
> special types unless absolutely necessary.

I don't disagree, just wanted to see that in the commit message. ;D

--
Jani Nikula, Intel