Re: [PATCH v2 1/8] drm/i915: move SKL clock gating init to display

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Apr 07, 2026 at 10:58:13AM +0300, Jani Nikula wrote:
> On Tue, 07 Apr 2026, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote:
> >> +void intel_display_skl_init_clock_gating(struct intel_display *display)
> >> +{
> >> +	/*
> >> +	 * WaFbcTurnOffFbcWatermark:skl
> >> +	 * Display WA #0562: skl
> >> +	 */
> >> +	intel_de_rmw(display, DISP_ARB_CTL, 0, DISP_FBC_WM_DIS); }
> >
> > Not sure about this being moved here but I feel like this belong in
> > intel_display_wa.c see that it is a WA
> 
> A lot of intel_clock_gating.c is about workarounds, and I don't really
> care a whole lot about moving these to intel_display_wa.c at this
> point. It's much more important to move the display related things from
> i915 core to display.

I still think it would have been much easier to move the gt stuff out
from init_clock_gating to the proper place in the gt code. And then we
could have just moved the remaining things into the display code as is.
But people seem to prefer the hard way for some reason :)

-- 
Ville Syrjälä
Intel