Re: [PATCH 4/5] drm/xe/multi_queue: Use QUEUE_TIMESTAMP as job timestamp for multi-queue

[Matthew Brost <matthew.brost@intel.com>]

On Thu, Apr 09, 2026 at 01:37:19PM -0700, Umesh Nerlige Ramappa wrote:
> Each queue in a multi queue group has a dedicated timestamp counter. Use
> this QUEUE TIMESTAMP register to capture the start timestamp for the
> job.
> 
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_ring_ops.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_ring_ops.c b/drivers/gpu/drm/xe/xe_ring_ops.c
> index cfeb4fc7d217..0eea37c0b4b2 100644
> --- a/drivers/gpu/drm/xe/xe_ring_ops.c
> +++ b/drivers/gpu/drm/xe/xe_ring_ops.c
> @@ -269,8 +269,12 @@ static u32 get_ppgtt_flag(struct xe_sched_job *job)
>  static int emit_copy_timestamp(struct xe_device *xe, struct xe_lrc *lrc,
>  			       u32 *dw, int i)
>  {
> +	const struct xe_reg reg = lrc->multi_queue.valid ?
> +				   RING_QUEUE_TIMESTAMP(0) :
> +				   RING_CTX_TIMESTAMP(0);
> +
>  	dw[i++] = MI_STORE_REGISTER_MEM | MI_SRM_USE_GGTT | MI_SRM_ADD_CS_OFFSET;
> -	dw[i++] = RING_CTX_TIMESTAMP(0).addr;
> +	dw[i++] = reg.addr;
>  	dw[i++] = xe_lrc_ctx_job_timestamp_ggtt_addr(lrc);
>  	dw[i++] = 0;
>  
> @@ -281,7 +285,7 @@ static int emit_copy_timestamp(struct xe_device *xe, struct xe_lrc *lrc,
>  	if (IS_SRIOV_VF(xe)) {
>  		dw[i++] = MI_STORE_REGISTER_MEM | MI_SRM_USE_GGTT |
>  			MI_SRM_ADD_CS_OFFSET;
> -		dw[i++] = RING_CTX_TIMESTAMP(0).addr;
> +		dw[i++] = reg.addr;
>  		dw[i++] = xe_lrc_ctx_timestamp_ggtt_addr(lrc);
>  		dw[i++] = 0;
>  	}
> -- 
> 2.43.0
>