Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
To: Tomasz Lis <tomasz.lis@intel.com>, <intel-xe@lists.freedesktop.org>
Cc: "Michał Winiarski" <michal.winiarski@intel.com>,
	"Piotr Piórkowski" <piotr.piorkowski@intel.com>,
	"Michal Wajdeczko" <michal.wajdeczko@intel.com>,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Matt Roper" <matthew.d.roper@intel.com>
Subject: Re: [PATCH v1] drm/xe/guc: Increase GuC log sizes in debug builds
Date: Thu, 19 Feb 2026 15:22:35 -0800	[thread overview]
Message-ID: <ae74545f-c804-455a-a28e-3e25b9aef7df@intel.com> (raw)
In-Reply-To: <20260213140008.1473400-1-tomasz.lis@intel.com>



On 2/13/2026 6:00 AM, Tomasz Lis wrote:
> Increase event log size for GuC debug to 16MB, and for general debug
> to 8MB. This allows for useful debug even if performance-affecting
> DRM_XE_DEBUG_GUC is not enabled.
>
> Without this change, GuC logs gathered by CI are useless for debug
> due to limited size, which translates to time frame not even able
> to cover cleanup after test.
>
> Signed-off-by: Tomasz Lis <tomasz.lis@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_guc_log.h | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_log.h b/drivers/gpu/drm/xe/xe_guc_log.h
> index 1b05bb60c1c7..4649a260755e 100644
> --- a/drivers/gpu/drm/xe/xe_guc_log.h
> +++ b/drivers/gpu/drm/xe/xe_guc_log.h
> @@ -13,9 +13,13 @@ struct drm_printer;
>   struct xe_device;
>   
>   #if IS_ENABLED(CONFIG_DRM_XE_DEBUG_GUC)
> -#define XE_GUC_LOG_EVENT_DATA_BUFFER_SIZE	SZ_8M
> +#define XE_GUC_LOG_EVENT_DATA_BUFFER_SIZE	SZ_16M
>   #define XE_GUC_LOG_CRASH_DUMP_BUFFER_SIZE	SZ_1M
>   #define XE_GUC_LOG_STATE_CAPTURE_BUFFER_SIZE	SZ_2M
> +#elif IS_ENABLED(CONFIG_DRM_XE_DEBUG)
> +#define XE_GUC_LOG_EVENT_DATA_BUFFER_SIZE	SZ_8M

Not sure if this is too big if we ever need to dump the guc log in dmesg 
in CI (AFAIK CI has a 2MB limit for dmesg, but we compress the log 
before dumping). We can tune it down later if we ever have issues, so 
I'm ok with going with 8MB for now.

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> +#define XE_GUC_LOG_CRASH_DUMP_BUFFER_SIZE	SZ_1M
> +#define XE_GUC_LOG_STATE_CAPTURE_BUFFER_SIZE	SZ_1M
>   #else
>   #define XE_GUC_LOG_EVENT_DATA_BUFFER_SIZE	SZ_64K
>   #define XE_GUC_LOG_CRASH_DUMP_BUFFER_SIZE	SZ_16K


      parent reply	other threads:[~2026-02-19 23:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 14:00 [PATCH v1] drm/xe/guc: Increase GuC log sizes in debug builds Tomasz Lis
2026-02-13 14:02 ` ✓ CI.KUnit: success for " Patchwork
2026-02-13 14:40 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-14 12:27 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-19  0:18   ` Lis, Tomasz
2026-02-19 23:22 ` Daniele Ceraolo Spurio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae74545f-c804-455a-a28e-3e25b9aef7df@intel.com \
    --to=daniele.ceraolospurio@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=michal.winiarski@intel.com \
    --cc=piotr.piorkowski@intel.com \
    --cc=tomasz.lis@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox